Giter Club home page Giter Club logo

Comments (6)

Nil8r93 avatar Nil8r93 commented on July 23, 2024

I was able to make the script work consistently by checking typeof(Danbooru) every 100ms (max 2 seconds) and only running bbbScript once typeof(Danbooru) becomes defined. I have essentially no experience with Javascript so this workaround is probably horribly inefficient, but I hope it helps anyway.
bbb-modified.zip

from better-better-booru.

 avatar commented on July 23, 2024

i have the same issue

it says i need a gold account for pay2see images and the script itself isn't appearing at all unless i wait a couple of minutes

from better-better-booru.

 avatar commented on July 23, 2024

Posting again from work. The problem definitely stems from the asynchronous change to Danbooru's JavaScript and I've basically got it pegged so that the script can continue to work like it has been via script managers and as a standalone script/extension. The answer lies in using a load even listener on Danbooru's script and modifying how the script detects whether it needs to embed itself as a standalone script. Assuming my schedule can line up with Pseudonymous' schedule when I'm back home, an update should be available this weekend (hopefully within the next 12 hours).

from better-better-booru.

 avatar commented on July 23, 2024

Actually, until I get home, feel free to test where the script is currently at for yourselves:
https://raw.githubusercontent.com/pseudonymous/better-better-booru/async-fix-test/better-better-booru.user.js

The version number won't change yet, but it is new. Changes can be viewed here:
0d74626

from better-better-booru.

 avatar commented on July 23, 2024

Didn't anticipate having to deal with Danbooru's new timing messing with the event listeners. I think I've combed through them and found the buggy parts. If nothing else turns up, cleaning up should be the only thing left... The previous link is the same link for the script in the progress.

Second revision changes from the first revision:
29f7da5

from better-better-booru.

 avatar commented on July 23, 2024

Officially pushed version 7.2.2 on GitHub so it should eventually make its way to GreasyFork.

GitHub link:
https://github.com/pseudonymous/better-better-booru/raw/master/better-better-booru.user.js

Related changes:
e733ffc
2b448cc

from better-better-booru.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.