Giter Club home page Giter Club logo

Comments (5)

xsist10 avatar xsist10 commented on August 16, 2024

Before I submit a pull request for this a couple of questions:

  1. The naming scheme for rules dealing with CVEs. Would you prefer a class name that conforms to a particular naming scheme (e.g.: Psecio\Iniscan\Rule\Cve\2013\1635) or something a bit more descriptive (e.g.: Psecio\Iniscan\Rule\CheckSoapWsdlCacheDir)?
  2. I'd like to extend Psecio\Iniscan\Rule to include a get/set version so the ini tool can be used to scan future problems with a php.ini before an upgrade/downgrade happens (also makes testing for version specific rules easier). Are you happy with that?

from iniscan.

enygma avatar enygma commented on August 16, 2024
  1. I think I'd like to stick with the descriptive name and just provide a link to the CVE in the header docs of the class. I'd rather people know what it's checking than what specific CVE it relates to.
  2. Yep, that's good by me - go for it.

from iniscan.

xsist10 avatar xsist10 commented on August 16, 2024

Found an interesting side-effect. Setting open_basedir to a folder that does not contain your CLI php.ini prevents PHP from being able to read the php.ini file which prevent the iniscan from working (obviously this is moot when scanning your apache/httpd/etc php.ini file).

from iniscan.

enygma avatar enygma commented on August 16, 2024

Huh, good point...chicken and egg sort of thing. I guess that's one limitation of using PHP to run a PHP check heh...

from iniscan.

enygma avatar enygma commented on August 16, 2024

Closing this issue as this check was added.

from iniscan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.