Giter Club home page Giter Club logo

Comments (3)

pschiffe avatar pschiffe commented on July 17, 2024 1

Hello @leleobhz, thank you for the detailed report. I'm proposing to change the health check to CMD ["curl", "-fsSLo", "/dev/null", "http://127.0.0.1:9494"]
This queries python app directly via uwsgi, skipping caddy. It checks if python app is working as well as the connection to the database. What do you think? Would that work in your setup?

from docker-pdns.

pschiffe avatar pschiffe commented on July 17, 2024 1

Hello @leleobhz, defining separate Caddy port with health check sounds like a good idea. The solution I chose for now bypasses Caddy completely, so there should be no issue with redirects. I think this is good enough for now, we can revisit later if needed. Cheers.

from docker-pdns.

leleobhz avatar leleobhz commented on July 17, 2024

Hello @leleobhz, thank you for the detailed report. I'm proposing to change the health check to CMD ["curl", "-fsSLo", "/dev/null", "http://127.0.0.1:9494"] This queries python app directly via uwsgi, skipping caddy. It checks if python app is working as well as the connection to the database. What do you think? Would that work in your setup?

Hello @pschiffe !

Sorry by late answer. I can try because I don't know if it avoids the 302 redirect issue.

I personally think about what I'm testing. If I'm testing admin frontend+backend availability, curl to a heath endpoint is the best way to do (And implement a /health in Caddy as example to return 200 or 500 depending of backend awnser), But If we test only for port being opened or close (Check if Caddy crashed, as example), bash test is more than enough.

Anyways, if this brace the case of 302 redirection, I think it satisfy this issue report and we can discuss this with time if you want.

from docker-pdns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.