Option to choose which PHP version to use about psalm.dev HOT 4 OPEN

Add a "php" database column (CHAR(3) DEFAULT NULL) and make sure the PHP version is persisted, if the user selected a specific version other than "Latest".

It will also need to be a part of slug calculation, so that snippets differing in version only have different urls.

from psalm.dev.

I think saving this info in the DB makes sense.

@orklah I don’t think the PHPStan way is really necessary — users rarely ticket issues where the version of PHP is decisive for the bug/feature.

from psalm.dev.

I'm thinking of tackling this issue with the following solution:

1. Add a PHP version select that defaults to "Latest" and make sure it gets passed to the right location.
2. Add a "php" database column (CHAR(3) DEFAULT NULL) and make sure the PHP version is persisted, if the user selected a specific version other than "Latest".

@muglug @weirdan Does this specification make sense to you, or do you have any remarks?

from psalm.dev.

I must say I really like PHPStan implementation: https://phpstan.org/r/13d9f782-9b40-4013-bc34-8177c6f5857b

Every version is checked so when there are differences, the versions appear clearly.

It even help users understand issues on their own when they see they aren't running the correct version

from psalm.dev.