Comments (8)
Well...I'd say that is in comparison to other PHP communities.
It may be a small percentage, but that percentage I would have to provide support for when the plugin stops working and deactivates on their website. Choose your battles! 🙂
from site-reviews.
BTW Come and see my ongoing research on plugin main file parts: https://github.com/szepeviktor/small-project/blob/master/MAIN-FILE-PARTS.md
There is a sample implementation included.
from site-reviews.
The v5.0.0 release was a big one due to the introduction of custom database tables. However, v5.0.0-5.1.0 did not support multisite so v5.2.0 was released quickly to fix this.
Because of the problems it introduced on multisite installs, I pulled the v5.0.x-5.1.x tags immediately as some people use https://wpackagist.org (i.e. https://roots.io/bedrock/).
If you would like to link to Site Reviews, I would change it to any tag after 5.2.0, or simply link to the master branch.
from site-reviews.
Thank you for the explanation!
If you would like to link to Site Reviews
I encourage you too to use namespaced functions, modern OOP technology and leave the PHP4-rooted WordPress approach behind.
from site-reviews.
I must admit there are a lot of things to learn from in this plugin.
from site-reviews.
That will all come in version 6.
The plugin has 20k+ active users and adoption of PHP 7+ is slower in the WordPress community. As much as I would like to use strict typing and all the modern features of PHP 7+, I can't release a minor version of the plugin that will cause it to deactivate for many users.
Version 5 brought a lot of changes and bumped the minimum WordPress version to 5.5 which is an easy upgrade for most people. Version 6 will bump the minimum PHP version, and enough time should have passed to not make it as big of a deal.
from site-reviews.
adoption of PHP 7+ is slower in the WordPress community
Do people say slower for 80% adaptation? :) https://wordpress.org/about/stats/#php_versions
from site-reviews.
Also, the plugin was first released before WordPress performed PHP version checking, so I left the activation logic as is for now. A few other things I'm not happy with is the naming structure, for example, "Modules" is misleading as those classes are not modular. Version 6 will change a few things in how the plugin is structured.
from site-reviews.
Related Issues (20)
- No styling and some settings does not work HOT 1
- Filter for using custom taxonomy instead of 'site-review-category' HOT 1
- Issue with assets path in local development HOT 1
- assigned_terms and assigned_posts not working properly in site_reviews_summary HOT 5
- 'Slow query' reported by Query Monitor HOT 18
- Error activating plugin HOT 2
- Add a new field. HOT 1
- Duplicate Queries wp_glsr_ratings HOT 6
- Review details disappeared from client webiste HOT 1
- site_reviews shortcode display, pagination issues with Elementor HOT 14
- Performance issue HOT 5
- cannot activate plugin due to new wordpress update 5.8.1
- test
- Pagination: load more feature HOT 1
- Spam submission protection HOT 6
- Function GeminiLabs\SiteReviews\Application->__get takes 0.555044 HOT 2
- Respond "quick edit" layout is broken
- Viewing Review Filter addon - 404 HOT 11
- Clarification about using Filter and Form addons HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-reviews.