Giter Club home page Giter Club logo

Comments (8)

pryley avatar pryley commented on June 14, 2024 1

Well...I'd say that is in comparison to other PHP communities.

It may be a small percentage, but that percentage I would have to provide support for when the plugin stops working and deactivates on their website. Choose your battles! 🙂

from site-reviews.

szepeviktor avatar szepeviktor commented on June 14, 2024

BTW Come and see my ongoing research on plugin main file parts: https://github.com/szepeviktor/small-project/blob/master/MAIN-FILE-PARTS.md
There is a sample implementation included.

from site-reviews.

pryley avatar pryley commented on June 14, 2024

The v5.0.0 release was a big one due to the introduction of custom database tables. However, v5.0.0-5.1.0 did not support multisite so v5.2.0 was released quickly to fix this.

Because of the problems it introduced on multisite installs, I pulled the v5.0.x-5.1.x tags immediately as some people use https://wpackagist.org (i.e. https://roots.io/bedrock/).

If you would like to link to Site Reviews, I would change it to any tag after 5.2.0, or simply link to the master branch.

from site-reviews.

szepeviktor avatar szepeviktor commented on June 14, 2024

Thank you for the explanation!

If you would like to link to Site Reviews

I encourage you too to use namespaced functions, modern OOP technology and leave the PHP4-rooted WordPress approach behind.

from site-reviews.

szepeviktor avatar szepeviktor commented on June 14, 2024

I must admit there are a lot of things to learn from in this plugin.

from site-reviews.

pryley avatar pryley commented on June 14, 2024

That will all come in version 6.

The plugin has 20k+ active users and adoption of PHP 7+ is slower in the WordPress community. As much as I would like to use strict typing and all the modern features of PHP 7+, I can't release a minor version of the plugin that will cause it to deactivate for many users.

Version 5 brought a lot of changes and bumped the minimum WordPress version to 5.5 which is an easy upgrade for most people. Version 6 will bump the minimum PHP version, and enough time should have passed to not make it as big of a deal.

from site-reviews.

szepeviktor avatar szepeviktor commented on June 14, 2024

adoption of PHP 7+ is slower in the WordPress community

Do people say slower for 80% adaptation? :) https://wordpress.org/about/stats/#php_versions

from site-reviews.

pryley avatar pryley commented on June 14, 2024

Also, the plugin was first released before WordPress performed PHP version checking, so I left the activation logic as is for now. A few other things I'm not happy with is the naming structure, for example, "Modules" is misleading as those classes are not modular. Version 6 will change a few things in how the plugin is structured.

from site-reviews.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.