Giter Club home page Giter Club logo

Comments (28)

WildyDS avatar WildyDS commented on June 9, 2024 3

I've also had this issue.
Investigated a lot, found a bug - ChromeTabsManagerActivity activity doesn't restore it's state after onDestroy which may happen even when visually it was not destroyed.

Steps to reproduce (tried on Samsung j320 and Samsung A5 (2016)):

  1. Open developer options
  2. Turn on "Do not keep activities" in "applications" part
  3. Open example app
  4. Open browser (here goes our "onDestroy")
  5. Try to close browser

The fix is in implementing "onSaveInstanceState" and checking for savedInstanceState in "onCreate" (also some related changes may be needed)

from react-native-inappbrowser.

Daha62 avatar Daha62 commented on June 9, 2024 2

Of course,
Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2019-04-18 Π² 14 32 29

from react-native-inappbrowser.

ssuchanowski avatar ssuchanowski commented on June 9, 2024 2

Happens to me as well - API 28, Nexus 5X but only on device - emulator seems to be working fine. I will try to investigate more.

from react-native-inappbrowser.

rizwanellahi avatar rizwanellahi commented on June 9, 2024 1

I am also facing this issue on Android 6.0.1

from react-native-inappbrowser.

Daha62 avatar Daha62 commented on June 9, 2024 1

https://drive.google.com/open?id=1EYdVV9C8dRicbHJANdOK3HowGgKCHoWI

from react-native-inappbrowser.

Daha62 avatar Daha62 commented on June 9, 2024 1

tried without singleTask mode, but on this device - the same behaviour.
On others - works as it should.

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024 1

Yeah... and I can't reproduce this issue, so try debugging the plugin and let me know what you find, in the meantime it would be closed πŸ‘

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

I'm going to check that at weekend, Any pull request is welcome in the meantime! πŸ‘

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

I need a demo to reproduce this issue, please let me know

from react-native-inappbrowser.

Daha62 avatar Daha62 commented on June 9, 2024

@jdnichollsc, I've just use
InAppBrowser.open('SOME_LINK')

And got unclosable browser.
And the BrowserResult type is dismiss instead of cancel (I checked it on other android and ios devices)

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

I can't reproduce this issue from Android 5.1.1 with the example project of this plugin, please attach a reproducible demo
Captura de Pantalla 2019-04-18 a la(s) 3 21 34 a  m

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

What's that?

from react-native-inappbrowser.

Daha62 avatar Daha62 commented on June 9, 2024

It's the answer of response as in ur screenshot.
InAppBrowser.open(link).then((response) => console.log(response))

Response returns: {type: 'dismiss'}

May be, if it helps: it reproduces on Samsung j-320. I don't know how to explain better.

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

@Daha62 try with the last version please and let me know πŸ‘

from react-native-inappbrowser.

Daha62 avatar Daha62 commented on June 9, 2024

@jdnichollsc thank u for ur updates. But the problem is still is still exist (

image

When I try to close it - browser opens again.

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

Are you using android:launchMode="singleTask"?

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

Can you attach a reproducible demo? I can't help you without that, sorry

from react-native-inappbrowser.

Daha62 avatar Daha62 commented on June 9, 2024

Are you using android:launchMode="singleTask"?

yep

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

try without android:launchMode="singleTask", let me check your link at night πŸ‘

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

Thanks @ssuchanowski, because I can't reproduce this issue and I can't help without a demo or logs of the issue :)

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

@Daha62 @Rizwanilahi @ssuchanowski @WildyDS what happen if you try opening the browser with the forceCloseOnRedirection property enabled? Just to know

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

@WildyDS honestly I don't know, but any pull request is welcome mate! πŸ‘

from react-native-inappbrowser.

Luke-Rogerson avatar Luke-Rogerson commented on June 9, 2024

@WildyDS So you're talking about the activity lifecycle, right? I'd like to help, but don't know enough about native Android code!

from react-native-inappbrowser.

WildyDS avatar WildyDS commented on June 9, 2024

@WildyDS honestly I don't know, but any pull request is welcome mate! πŸ‘

I can actually do it in my spare time but in won't be soon

from react-native-inappbrowser.

WildyDS avatar WildyDS commented on June 9, 2024

@WildyDS So you're talking about the activity lifecycle, right? I'd like to help, but don't know enough about native Android code!

Exactly

from react-native-inappbrowser.

marudy avatar marudy commented on June 9, 2024

Hey guys, just run into this as well. Any work around or patch suggested? Thanks

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

@WildyDS thanks for your help, it was fixed in the last version 3.3.0, let me know πŸ‘ https://github.com/proyecto26/react-native-inappbrowser/releases/tag/v3.3.0

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

And guys, let me know what you think v3.2.0...v3.3.0

from react-native-inappbrowser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.