Giter Club home page Giter Club logo

Comments (12)

rborn avatar rborn commented on June 9, 2024 4

OMG 🙀, gradlew clean aaaaand it runs with the "react-native-inappbrowser-reborn": "https://github.com/proyecto26/react-native-inappbrowser.git",🎉
Thanks a lot ❤️

from react-native-inappbrowser.

rborn avatar rborn commented on June 9, 2024 1

from react-native-inappbrowser.

rborn avatar rborn commented on June 9, 2024 1

@jdnichollsc let me gradlew clean..

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

@rborn it looks an issue with the installation if RNInAppBrowser is undefined :)

from react-native-inappbrowser.

rborn avatar rborn commented on June 9, 2024

Here is my setup:
MainApplication.java

import com.proyecto26.inappbrowser.RNInAppBrowserPackage;
...

new RNInAppBrowserPackage(),

app/build.gradle

implementation project(':react-native-inappbrowser-reborn')

settings.gradle

include ':react-native-inappbrowser-reborn'
project(':react-native-inappbrowser-reborn').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-inappbrowser-reborn/android')

while compiling it finds the module


> Configure project :react-native-inappbrowser-reborn 
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
WARNING: The specified Android SDK Build Tools version (27.0.3) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.2.1.
Android SDK Build Tools 28.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '27.0.3'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

however it doesn't work :(

RN 0.57.4

and android

ext {
        buildToolsVersion = "27.0.3"
        minSdkVersion = 21
        compileSdkVersion = 28
        targetSdkVersion = 27
        supportLibVersion = "28.0.0"
        googlePlayServicesVersion = "15.0.1"
        androidMapsUtilsVersion = "0.5+"
    }

from react-native-inappbrowser.

rborn avatar rborn commented on June 9, 2024

@jdnichollsc I can confirm that is not in the NativeModule - it seems it's not registering itself for somehow

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

@rborn I don't know if I can remove the build configuration https://github.com/proyecto26/react-native-inappbrowser/blob/master/android/build.gradle#L15
Let me try

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

@rborn can you try the last version of this repository? https://github.com/proyecto26/react-native-inappbrowser/blob/master/android/build.gradle
Please let me know to publish from npm

from react-native-inappbrowser.

rborn avatar rborn commented on June 9, 2024

the same :(

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

I don't understand, are you pointing to this github repo from the package.json?

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

Ok, let me publish a new version

from react-native-inappbrowser.

jdnichollsc avatar jdnichollsc commented on June 9, 2024

Done, check the last version from npm!

from react-native-inappbrowser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.