Giter Club home page Giter Club logo

Comments (5)

wanthalf avatar wanthalf commented on June 6, 2024

As for me, loading the whole corpus in a single file is rather a burden anyway. A three level index would be more useful (file, sentence, token). But that would probably require larger changes of the whole architecture, I am afraid. And adding a third number to the index wouldn't solve the problem, even if both the "file" and "sentence" pointers remain 32-bit - together they still make up 64 bits.

from colibri-core.

proycon avatar proycon commented on June 6, 2024

This current line of implementation is a rather major refactoring which will take some more time, so I'm gonna start again and try a more 'quick' fix, although that might come at increases memory cost in certain computations.

from colibri-core.

proycon avatar proycon commented on June 6, 2024

As for me, loading the whole corpus in a single file is rather a burden anyway. A three level index would be more useful (file, sentence, token). But that would probably require larger changes of the whole architecture, I am afraid.

Yeah, that would be another major refactoring. I don't think we can go in that direction. You'd have to solve that in some wrapper stage (mapping file,sentence to some kind of aggregated sentence)

And adding a third number to the index wouldn't solve the problem, even if both the "file" and "sentence" pointers remain 32-bit - together they still make up 64 bits.

Indeed, that would come at an extra memory penalty so I don't want to go there.

from colibri-core.

proycon avatar proycon commented on June 6, 2024

Solved in v2.5.0 release

from colibri-core.

proycon avatar proycon commented on June 6, 2024

Last but not least, benchmarks of 32-bit size descriptors vs 64-bit size descriptors (in patterpointers) show a small increase in peak memory:

benchmarks32.txt
benchmarks64.txt

from colibri-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.