Configure linter and run it on CI about protoschool.github.io HOT 6 CLOSED

Is it possible this particular case wasn't picked up as an error by the linter because the string had an apostrophe inside it and couldn't have been produced with single quotes surrounding it? If so, maybe there's a way to add our own rule to require ` instead of " around the string in that case?

from protoschool.github.io.

Is it possible this particular case wasn't picked up as an error by the linter because the string had an apostrophe inside it and couldn't have been produced with single quotes surrounding it?

This is absolutely why :)

from protoschool.github.io.

from protoschool.github.io.

This still needs to be tackled: " add npm run lint to the travis config so we get feedback on PRs"

However, it's a little more involved than that. Our current travis config is for gh-pages deploys so it doesn't run on every PR, it only runs on merges to master.

from protoschool.github.io.

May I assign this one to you @mikeal so I can stay focused on site content for the time being? (Happy to have you grab me when you're doing it if you want to show me how it works; I don't know anything about this kind of plumbing.)

from protoschool.github.io.

Sure, I'll assign it to myself to save you the hassle :)

from protoschool.github.io.