Giter Club home page Giter Club logo

Comments (12)

mikeal avatar mikeal commented on June 11, 2024 1

Ok, I've added exersize and concepts properties alongside text which operate the same (they get passed through markdown and inserted into the page if they are there).

It still needs to be styled. I'm using the properties in Basics/01.

from protoschool.github.io.

olizilla avatar olizilla commented on June 11, 2024

Adding an instruction below the editor box gives a place to put feedback after validation:

Initial
protoschool-lesson-test-1

Wrong answer
protoschool-lesson-test-2

OOH YEAH
protoschool-lesson-test-3

from protoschool.github.io.

olizilla avatar olizilla commented on June 11, 2024

Also rather than embedding the IPLD explorer this simplifies things be just offering the options to open it in a new tab.

from protoschool.github.io.

mikeal avatar mikeal commented on June 11, 2024

Love it.

How do we define content that sits in the glossary vs exercise vs lesson?

from protoschool.github.io.

olizilla avatar olizilla commented on June 11, 2024

Probably just 3 separate .md files.

  • 01.md - Required, ideally contains instructional text that explains a concept.
  • 01-exercise.md - Optional, goes in the box above the editor, defines the requirements for the coding challenge.
  • 01-concepts.md - Optional, shows up in the box out if present. This can just be markdown too. We could make it structured, but let's just do the simplest thing to start with.

from protoschool.github.io.

terichadbourne avatar terichadbourne commented on June 11, 2024

@olizilla @mikeal Should this issue still be open or do you feel that it's been resolved?

The only thing I notice at first glance as a difference between Oli's screenshots here and the live site is that hexagonal "You Did It" badge in yellow appearing at the top right of the exercise box. Do we want that, or some version of that in a simpler form (for example, a trophy emoji built into the success message that appears in the green bar, or just want to make sure our success messages give people warm fuzzy feelings?

from protoschool.github.io.

terichadbourne avatar terichadbourne commented on June 11, 2024

Oh, just realized that the 'reset' button has also not been implemented (see related issue #13). Is there a branch where that code already exists but hasn't been merged to master? Or has the task not been tackled yet?

from protoschool.github.io.

mikeal avatar mikeal commented on June 11, 2024

I think it just hasn't been tackled yet.

from protoschool.github.io.

terichadbourne avatar terichadbourne commented on June 11, 2024

Okay, so creating a reset button is still on the to do list. Do we feel strongly about adding that "You did it" hexagon @olizilla proposed? Anything else from this issue that still needs building?

Action items:

  • Make reset button that clears anything you've typed in the exercise box, resetting it to its original state.

from protoschool.github.io.

mikeal avatar mikeal commented on June 11, 2024

Rather than having a "reset" button, can we note that we've loaded code from a saved state and the present a reset link/button in the text?

It's not super clear in the current mocks when we're in a saved state or not.

from protoschool.github.io.

terichadbourne avatar terichadbourne commented on June 11, 2024

If we're talking about having an actual saved state that we're choosing to abandon, rather than just deleting the never-saved changes we've made in the text box, let's move the convo over to issue #13, where I've asked for some related suggestions on how to approach this. I'll copy your question over there @mikeal.

from protoschool.github.io.

terichadbourne avatar terichadbourne commented on June 11, 2024

Closing this one as all of the features proposed in this issue have either been implemented already or are in the works as part of issue #13 and WIP PR #86 (which relate to saving state).

from protoschool.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.