Comments (5)
@galargh Not urgent, but I'm flagging this to make sure we look into it when you're back.
from .github.
https://github.com/laurentsenta/pl-dotgithub/blob/7af09622b400698bd74012143dcbcc1e04e21801/.github/workflows/release-check.yml#L6 <- this makes sense to me. Could you turn it into a PR?
from .github.
Could you confirm we want to remove that required
flag?
I thought we'd fix it on a case-by-case basis and then remove the default value:
https://github.com/laurentsenta/pl-dotgithub/blob/7af09622b400698bd74012143dcbcc1e04e21801/.github/workflows/release-check.yml#L8
If we drop the required
flag, we have to keep the default value.
from .github.
Could you confirm we want to remove that
required
flag? I thought we'd fix it on a case-by-case basis and then remove the default value: https://github.com/laurentsenta/pl-dotgithub/blob/7af09622b400698bd74012143dcbcc1e04e21801/.github/workflows/release-check.yml#L8If we drop the
required
flag, we have to keep the default value.
That's fair enough. Let's keep it open until we upgrade everywhere but let's not take any action now.
from .github.
Related Issues (20)
- Should we support opting out of 32bit tests in go-test workflow? HOT 11
- `gorelease` output contains module downloads
- Allow JS test customization HOT 1
- Remove set-output and save-state commands from workflows HOT 1
- Add github action for nightly build HOT 2
- Support protected branches for the js release flow
- can't use GitHub secrets in repo-specific setup HOT 3
- uCI Release: Go v1.20.0 HOT 13
- Go test -cover breaks certain tests HOT 3
- Cache go modules and build cache HOT 2
- Better go linters HOT 2
- Automerge might starve other workflows HOT 1
- Unified CI config update job broken on all js repos HOT 1
- draft release notes not updated on force push HOT 1
- patch release incorrectly cut on master, not on release branch
- Commit messages in auto-merged PRs do not follow conventional commits HOT 1
- Disable codecov annotations on PRs HOT 2
- Release Check workflow not comparing the correct versions for Golang RCs
- Thoughts about the future of Unified CI HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from .github.