Giter Club home page Giter Club logo

Comments (3)

domenic avatar domenic commented on May 22, 2024

Yes, the spec defines that the error is captured as the rejection reason of the promise returned from then:

3.2.6.2 If either onFulfilled or onRejected throws an exception, promise2 must be rejected with the thrown exception as the reason.

You seem to be throwing away that returned promise (promise2 in the spec), which is the root of your problem.


As always, consider the sync analog.

promiseSomething().then(function(result){
  var s = new SomeObj();
  s.doSomething(); // this error is swallowed
}, function(){
  // this obviously won't catch the error
});

becomes

try {
  promiseSomething();
} catch {
  // this obviously won't catch the error
}

var s = new SomeObj();
s.doSomething(); // this error is not caught

where obviously the error will not be caught. However, if you add the .then(undefined, function errhandler(){}) as you suggest, it becomes

try {
  promiseSomething();
} catch {
  // this obviously won't catch the error
}

try {
  var s = new SomeObj();
  s.doSomething();
} catch (err) {
  errhandler(err);
}

See also this explanation over in the Q readme.


We are discussing how to fix the problem that, with promises, errors are swallowed instead of handled by the host platform, over in the unhandled rejections spec area. In particular, see this background thread.

from promises-spec.

kirbysayshi avatar kirbysayshi commented on May 22, 2024

Ah thanks.

Glad to hear it's being discussed, and thanks for pointing out the Q readme point. I'd read that before, but not while tackling my own implementation.

I just implemented my own console.unhandledRejection checking and it's working nicely.

Thanks again!

from promises-spec.

domenic avatar domenic commented on May 22, 2024

I just implemented my own console.unhandledRejection checking and it's working nicely.

That'll be sweet!

from promises-spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.