Tag 1.0.0 about promises-spec HOT 13 CLOSED

👍 The only minor nit I see is 3.2.5.1 and 3.2.5.2 starting with "if". Changing it to "if/when" or "in the fulfilled state" may be better.

from promises-spec.

👍

from promises-spec.

👍
Agreed with @briancavalier on changing 3.2.5.1 and 3.2.5.2 to "if/when".

One non-content related nit: the gh-pages version of the doc numbers the footnotes as 4.1, 4.2, and 4.3, which doesn't match the links to those footnotes.

from promises-spec.

👍 agree on nits.

from promises-spec.

@lsmith great catch! I'll fix these nits shortly.

from promises-spec.

Hmmm, anyone know what's up with 3.1.1?? Why is the sub-bullet not actually a sub-bullet. Looking at the markdown, it's not obvious what is going wrong--maybe a jekyll/gh-pages problem?

from promises-spec.

Nits fixed. If we can figure out the sub-bullet problem, I think we'll be ready.

from promises-spec.

Weird. yeah. Even this comment box supports the formatting as written in the README.md

Requirements

Promise States

A promise must be in one of three states: pending, fulfilled, or rejected.

1. When in pending, a promise:
   1. may transition to either the fulfilled or rejected state.
2. When in fulfilled, a promise:
   1. must not transition to any other state.
   2. must have a value, which must not change.
3. When in rejected, a promise:
   1. must not transition to any other state.
   2. must have a reason, which must not change.

from promises-spec.

It'd also be cool to get a domain name.

from promises-spec.

I totally agree about the domain name--that'll be very cool. I think we can go ahead and tag without it, tho.

Anyone know how we might get a domain name for free? Figured I'd at least ask :)

from promises-spec.

Ok, I found a way to work around the apparent jekyll bullet rendering bug in 3.1.1. If there are no other nits by tomorrow afternoon EST, I'll tag.

from promises-spec.

Ok, all, we're 1.0.0 now :) Feel free to tweet it up (although I'll prolly wait for a more optimal tweet time :) )

from promises-spec.

woohoo! I had a beer in celebration last night.

from promises-spec.