Comments (4)
Knappek
commented on May 27, 2024
Thanks @leojonathanoh for the heads up. I think it is not a good idea to expose any kind of secrets at all, in general. So I removed it in #76 . Would be great if you can review.
from prometheus-msteams.
leojonathanoh
commented on May 27, 2024
would it be better if #76 was split up into two PRs, one addressing this issue and the other addressing #73?
I'd consider a fix for this to be a bugfix, whereas a fix for #73 I'd consider to be breaking for some users who have been reliant or expect some kind of verbose logging. I'm not familiar enough with the release cycle, so I'll leave it to you guys to decide whether to split the PR up :)
from prometheus-msteams.
Knappek
commented on May 27, 2024
I don't think not printing secrets is a breaking major change. I would just go ahead and put it in a patch version upgrade. @bzon any concerns?
from prometheus-msteams.
Knappek
commented on May 27, 2024
addressed in #76
from prometheus-msteams.
Related Issues (20)
- [BUG] Helm repo no longer working HOT 4
- [FEATURE] Upgrade github.com/go-kit/kit to 0.12.0
- Release dependeny updates HOT 1
- Direct integration into Alertmanager? HOT 5
- [BUG] Give up the way to run "prometheus-msteams" in docker
- Image ARM Architecture HOT 2
- Grafana dashboard
- [BUG] Simulating a Prometheus Alerts to Teams Channel - results in not found
- Security Vulnerability [BUG]
- [BUG] cannot recieve alerts in MSTeams HOT 1
- [BUG] services dies when using systemctl reload prometheus_msteams.service HOT 1
- [BUG] Invalid memory address on Kubernetes v1.24 HOT 3
- [Message: Not Found] using uir static or dynamic. No Alerts are send to Teams channel
- Sunset of this repository HOT 3
- [BUG] When alerts are grouped, the card does not differentiate between status firing and resolved
- [BUG] Image tag v1.5.2 is not available anymore
- [FEATURE] Turn off automountServiceAccountToken
- [FEATURE] Timeline of new release HOT 4
- [BUG] The DEBUG logging level cannot be changed
- [BUG] Unable to pull the image from M2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prometheus-msteams.