Giter Club home page Giter Club logo

Comments (5)

mrgrain avatar mrgrain commented on June 7, 2024 1

Yes please if you can! Make sure you add a test case for it.

I'm guessing the fix will be to have a more elaborate regex to match the version string?

from projen.

mrgrain avatar mrgrain commented on June 7, 2024

Looks like you are dealing with an inconsistent state here? You don't have a v0.0.1 tag yet, but already have a changelog entry for it. projen is quite likely not able to deal with these kind of inconsistency in a way that suits everyone.

What would you expect instead here? A hard error?

from projen.

suhussai avatar suhussai commented on June 7, 2024

Did projen somehow create changelog entry before or was it confused because I already had changelog entries for the previous beta-release tags (like v0.0.1-beta.0 and v0.0.1-beta.1)? I was thinking it was the latter because the tag strings for the beta releases like v0.0.1-beta.0 (that would be present in the changelog) contain the string v0.0.1, so it's possible that based on the check in the line I linked, projen is assuming that the changelog entry already exists.

Does that make sense or am I off-base here?

from projen.

mrgrain avatar mrgrain commented on June 7, 2024

No my bad, I think you are right. Misread the code and your comment. 🤦‍♂️

from projen.

suhussai avatar suhussai commented on June 7, 2024

No worries. Should I create a PR to address this?

from projen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.