Giter Club home page Giter Club logo

Comments (3)

jarrodmcc avatar jarrodmcc commented on July 18, 2024

Hi,

Thank you for your feedback and help in improving the code. It's actually okay that the one-body integrals are negative, but I looked into the issue of the overlap matrices and it turned out that was an error in FermiLib that was accidentally loading the one_body_integrals in place of the overlap integrals, because the overlap integrals were never loaded. This is because we made a design decision some time ago to only work with orthonormal basis sets (specifically we load the orbitals in the hartree-fock canonical basis), which means the overlap matrix is always the identity. To reduce confusion and eliminate this problem, we will remove the overlap_integrals field altogether from molecular data. Thanks again!

from fermilib-plugin-psi4.

babbush avatar babbush commented on July 18, 2024

Thanks Jarrod!

from fermilib-plugin-psi4.

TariniHardikar avatar TariniHardikar commented on July 18, 2024

Oh, alright! Thank you!

from fermilib-plugin-psi4.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.