Giter Club home page Giter Club logo

Comments (3)

ProjectPhysX avatar ProjectPhysX commented on June 7, 2024 1

Hi @rodionstepanov,

I can replicate this issue, full 8 minutes for 1024x512x512 on 2x Xeon E5-2680 v3, 48 threads. Digging in the internet, I found the root cause: gcc's std::rand() is dog slow with multithreading, as it contains a mutex lock.

If I change the initialization loop in main_setup() from

parallel_for(lbm.get_N(), [&](ulong n) { ... });

to

for(ulong n=0ull; n<lbm.get_N(); n++) { ... }

to run single-threaded, it's down to 2 minutes from 8.

I have now replaced std::rand() with the standard C99 LCG function; this is suitable for multithreading and brings multithreaded initialization down to 1 minute. Please update!

Kind regards,
Moritz

from fluidx3d.

rodionstepanov avatar rodionstepanov commented on June 7, 2024 1

@ProjectPhysX , thanks a lot. I've updated and it is fast and furious now 🥇

from fluidx3d.

ProjectPhysX avatar ProjectPhysX commented on June 7, 2024

Hi @rodionstepanov,

interesting observation, I wasn't aware of this. random_symmetric() is no more than a std::rand() call internally. During initialization you should see the CPU go to full load on all cores, on both systems; I added this multithreading in update 2.9. Maybe the CPU in your Linux system is weaker? Or maybe the rand() call with g++ does something weird? I'll test this myself and try to replicate.

Thanks and kind regards,
Moritz

from fluidx3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.