Do not create partition on devices about container-storage-setup HOT 3 CLOSED

This creates another problem. If somebody specifies DEVS=vdb, we create partition /dev/vdb1 and add it to volume group. Now next time d-s-s runs it exits with error saying that vdb is a partitioned device. This is wrong. A user is not supposed to edit the /etc/sysconfig/docker-storage-setup again after pool has been created.

from container-storage-setup.

While I have nothing against using LVM on the raw device directly, the RHEL LVM Administration guide does suggest creating a single partition spanning the entire disk, and then use that partition with LVM. I would say it would be best to keep things consistent.

Red Hat recommends that you create a single partition that covers the whole disk to label as an LVM physical volume for the following reasons:

• Administrative convenience
  It is easier to keep track of the hardware in a system if each real disk only appears once. This becomes particularly true if a disk fails. In addition, multiple physical volumes on a single disk may cause a kernel warning about unknown partition types at boot.
• Striping performance
  LVM cannot tell that two physical volumes are on the same physical disk. If you create a striped logical volume when two physical volumes are on the same physical disk, the stripes could be on different partitions on the same disk. This would result in a decrease in performance rather than an increase.

from container-storage-setup.

I agree. For now I am closing it.

from container-storage-setup.