Comments (8)
would you expect this to also address adding version specific flags automatically? For instance docker-1.9.1 added dm.use_deferred_deletion=true
and it'd be nice to get that during upgrades by merging machine generated and user modified.
from container-storage-setup.
Now we have a config option "EXTRA_DOCKER_STORAGE_OPTIONS", where one can specify the config options to pass to docker.
from container-storage-setup.
So this issue can be closed then, right?
Probably a different issue, but If I upgrade from docker-1.8.2 to docker-1.9.1, assuming d-s-s runs when docker starts, will I get the new options defined?
from container-storage-setup.
I think this particular issue can be closed. What you are asking for is a different issue.
I think right fix for your issue is to enable deferred deletion and deferred removal by default in docker that way over an upgrade customer automatically gets it.
Now docker has done changes in their systemd unit file to run docker daemon in host namespace by default. That means lot of leaking of mounts across namespaces and that also means lot more need to enable deferred deletion and deferred removal by default. So may be docker will be open to it now. If not, we should think of carrying a patch for docker for fedora.
from container-storage-setup.
cc @shishir-a412ed Would you like to propose enabling deferred removal and deferred deletion by default upstream?
from container-storage-setup.
Yes @shishir-a412ed propose that and explain the leaking of open file descriptors caused by running docker in the host namespace.
from container-storage-setup.
@rhvgoyal @rhatdan ack. Will open a PR upstream.
from container-storage-setup.
@rhvgoyal @rhatdan
moby/moby#23590
Shishir
from container-storage-setup.
Related Issues (20)
- still some docker-storage-setup* files present HOT 6
- One bad config is not ignored HOT 9
- get_docker_storage_options() should be generalized for inputfile case too HOT 3
- `/var/lib/containers` conflicts with system containers HOT 6
- NVMe Device Configuration HOT 5
- Add support for Docker daemon "-g" start up option to point to LVM-direct mount HOT 17
- Fix selinux file labels when set CONTAINER_ROOT_LV_MOUNT_PATH to a directory other than /var/lib/docker HOT 3
- "atomic storage reset" fails if /var/lib/docker is mounted HOT 6
- support `ROOT_SIZE=100%FREE`
- docker-storage-setup.service not found HOT 27
- Attempted to use RAID0, fails partition check HOT 1
- container-storage-setup fails when updating Atomic Host OS on existing system HOT 26
- should setting `CONTAINER_ROOT_LV_MOUNT_PATH` also update docker to not point at `/var/lib/docker` ? HOT 4
- Overlay2 not supported on CentOS-Atomic-Host-7.1804+
- On aws with nvme the script always adds after reboot wrong disk on lvm HOT 1
- Docker Storage Setup Not Configuring Docker HOT 4
- fstype is checked at wrong folder lever HOT 2
- Crypt devices unsupported HOT 1
- Failed mount does not lead to startup error
- "container-storage-setup create" does not create SystemD's mount unit file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from container-storage-setup.