Comments (8)
On further inspection, various widgets in AddGameWizard need parents as well.
from client.
Noted, will amend in the refactor inbound. Muchas gracias, senor.
from client.
Just curious about design decisions, why aren't managed pointers such as unique_ptr<T>
and shared_ptr<T>
being used? I don't see the reason behind using raw pointers in 2015 unless one is working with legacy code. In terms of performance, compilers can optimize unique_ptr
s to the same machine code as raw pointers.
If it's just a matter of somebody doing it, let me know.
from client.
Because there's no need for ownership or sharing and the objects won't outlive the parent. Not relevant to the issue.
Sent from my Android device with K-9 Mail. Please excuse my brevity.
from client.
To elaborate on the response by @elken above, Qt by nature favors heap-allocation of local QObjects for a number of reasons, opting to manage memory hierarchically throughout the application when respective QObjects are parented to one another. In this issue, some parents were never set, hence the memory leakage.
The sheer amount of QObjects we're initializing programmatically now and in the future favors raw pointers as a form of brevity, though yes, in any other case we would be doing otherwise.
from client.
To further elaborate, we also want raw pointers as arguments and as local variables for the speed and leanness of just an address, we don't need the overhead *_ptr
types provide.
from client.
Issue seems to be resolved, reopen if not.
from client.
The memory leak still occurs on both wizards: http://i.imgur.com/Jd5Ztm0.gifv
from client.
Related Issues (20)
- Potential registry/QDir issue HOT 2
- Some DB connections are not being closed. HOT 3
- Create Library UI Programmatically HOT 1
- Compilation error HOT 1
- Compilation error HOT 6
- Invalid Magic Value HOT 3
- Database error reported by /u/TIFUbyredditting HOT 1
- Idea for adding non-game platforms games.
- I don't have a libraryFolders.vdf file. HOT 1
- Windows tray icon doesn't work on mingw
- Don't put DDP-specific stuff into Library.cpp HOT 4
- Possible issue RE: differences in registry keys on 32 bit versions of Windows HOT 4
- Some Steam games crash if not launched via Steam HOT 6
- Reopen issue #5
- Add Mozilla Persona HOT 2
- Move BorderlessWindow to a submodule HOT 1
- Slack test
- Steam games with multiple exe's are ignored
- Reduce Semaphore Buildtimes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.