Bug: Games should be public about ladder HOT 4 CLOSED

I think there should be an application setting for both games and challenges to be either:

1. Limited to the games and challenges the current user is participating in
2. Limited to the tournaments the current user is participating in

And option 2 would be my preference.

What do you think, @proglottis?

from ladder.

I'm not terribly interested in an application level setting. Perhaps tournament level. Ultimately I tend to agree that games should be public in the same way that challenges are (option 2). Originally I thought that I'd be too embarrised that my boss/coworkers would know how much pool I play 😄

As well as this change, I've thought about having a "public" tournament setting. Where even unauthenticated person could see the tournament listing - but none of the games/challenges. Also possibly with the option to request an invite.

All this would be loads easier with the player model refactor I'm working on. I created a pull request for it #20 so you guys can help if you want. Such a huge change though - I'm nowhere near finished. This is like attempt number 5. Trying to keep things in small digestible steps without a 1000 line diff.

from ladder.

I wish I could have helped out with #20 but I'm too much of a rails newbie. Did your recent merge tackle everything you had planned? Or is it a multi-step process?

from ladder.

Still need to remove the user_id columns from game_ranks and ratings. Also need to migrate challenges to use players instead of users. There's a bunch of code around that is really gross too (and not tested properly). Such as this. Quite a few controller actions are doing too much without a transaction or anything.

I think I want to end up with something like this:

from ladder.