Comments (6)
I looked through the file for 'undefined' and found places where you are already doing the check that way. Are there other instances I should be looking for?
from p5.js.
@evhan55 there are a few places I'm doing it correctly (using typeof) but there are a lot of overloaded fxns where I'm distinguishing between types by checking if the last args exist. for example:
https://github.com/lmccart/processing-js/blob/master/lib/pjs.js#L1016
should remove check if (x) and replace with if (typeof x === 'undefined'), etc.
from p5.js.
@lmccart cool, I see now, ok I will look for them
Bocoup training also suggests treating method overloads with this check:
if(arguments.length === 0) { then do this thing }
etc.
but I will keep typeof !== 'undefined' for now
from p5.js.
@evhan55 oh that's a good point... go with that instead if you think it's better!
from p5.js.
@lmccart I'll stick with typeof for now and we can see later!
from p5.js.
closing for now and opening a new one about typeof vs. arguments
from p5.js.
Related Issues (20)
- [p5.js 2.0 RFC Proposal]: New third party library authoring API
- [p5.js 2.0 RFC Proposal]: Renderer system refactor HOT 8
- [p5.js 2.0 RFC Proposal]: RNG algorithm change HOT 2
- [p5.js 2.0 RFC Proposal]: Color module rewrite HOT 14
- Is the index missing in `setName` from `p5.XML`? HOT 1
- p5.Vector.sub() Reference documentation has a typo in description HOT 2
- [p5.js 2.0 RFC Proposal]: Typography module revamp HOT 11
- textFont() doesn't work for WebGL outside of preload() for loading fonts unlike P2D which isn't specified HOT 10
- Image uniforms get reset after each draw using a shader HOT 10
- [p5.js 2.0 RFC Proposal]: Shader Hooks HOT 2
- How to change color of all circles?? HOT 2
- `nf()` produces problematic string-formatting of negative numbers
- `p5.XML.listChildren()` inserts `#text` unexpectedly HOT 7
- `p5.Framebuffer.remove()` doesn't remove some resources HOT 2
- `p5.Graphics.remove()` doesn't remove some resources HOT 6
- missing link in documentation_style_guide.md HOT 2
- Fix broken link in documentation_style_guide.md
- Should setCamera() also call resetMatrix()? HOT 6
- Suggestion of a function to get screen coordinates HOT 16
- get() and/or pixelDensity() lag since v1.8.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from p5.js.