Giter Club home page Giter Club logo

Comments (5)

jhimpele avatar jhimpele commented on August 15, 2024 1

Looks good. I have a few related points, perhaps for next week: the tradition and events "rows" or bands can be removed. Should we keep the branch names as placed above them? And there will only be one item on the trunk (the plaque). And let's continue our discussion of how to make the trunk appear as a single trunk...shading? Otherwise, I think we are looking good with Overlock!

from lenape-timetree.

rlskoeser avatar rlskoeser commented on August 15, 2024 1

@gissoo the sizes all look good to me; everything seems very readable and I like how the Overlock is working out; glad it was a good solution for the sizing.

In the table of font sizes and styles, under navigation, you have "mobile: footer default" repeated, I think the second one should be selected (it looks like you forgot to change the name, I can tell from the styles).

You list buttons and tags in the nav section, do they use the same type styles as footer default?

It looks like these are ready to implement, would you create an implementation issue when you close this design issue?

from lenape-timetree.

gissoo avatar gissoo commented on August 15, 2024

@rlskoeser @jhimpele

  • please take a look at the type sizes I've proposed for desktop and mobile here on Figma and let me know what you think
  • You can look at them on the desktop and mobile layouts or the typography table I've created.
  • I've included some of the leaf titles on desktop as a way to test.

I'm moving forward with Overlock as it was more promising than Ubuntu as far as its base scale and kerning.

Note: the site title/display font is out of scope for this issue, I'll address it in another issue soon.

from lenape-timetree.

gissoo avatar gissoo commented on August 15, 2024

@jhimpele thank you for writing. I have removed the traditions and events and left one circle as an indicator for the plaque in the trunk. The revised tree style will be in a separate issue. About the placement of the leaf labels I'm not sure, having a difficult time seeing them all placed the same way, it would be helpful to test that in implementation because the spacing within the visualization displayed in Figma won't be matching the implementation.

from lenape-timetree.

gissoo avatar gissoo commented on August 15, 2024

@rlskoeser thanks for writing! I have fixed the table, yes, they will use the same type styles and footer default, I've fixed the label so it says tags and footer. But we don't have text "buttons". I'll eliminate that

from lenape-timetree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.