Formally add internal-repo icon about octicons-v2 HOT 17 CLOSED

@edokoa I like these but feel it might be hard to discern the avatar for our enterprise customers in within this space. I think I still prefer this version better since it gives an indication that the repo exists within the enterprise account and ties together with our icon for "enterprise"

That being said, I do think we could connect it more so that it doesn't feel as if the avatar is a bat signal 😂

from octicons-v2.

It’s not entirely clear from the screenshot in the original message up top, but the GitHub logo is actually not part of the icon. We show the org avatar of whatever the user’s org is in that negative space.

from octicons-v2.

I was doing some tests with other org icons. We could use the small repo icon combined with a 30x30 org icon (half the normal size).

cc @jasonlong @CamiloGarciaLaRotta

from octicons-v2.

👋🏽friendly bump from iam as we currently are hardcoding the SVG in :repo/settings/access which happens to render badly in Safari https://github.com/github/github/issues/133353

from octicons-v2.

@colebemis @edokoa we will need to add this to Octicons v2 as well. i will take care of adding the current icon to v1 for now.

@jasonlong do we have the Figma file for this or just the source svg?

from octicons-v2.

It means "internal to an enterprise" in general.

from octicons-v2.

@ashygee If there's a figma file for it, @pmarsceill would have it. It may even be from the Sketch days of yesteryear.

from octicons-v2.

@ashygee I found it. DMing to you.

from octicons-v2.

I made a few quick explorations. Would we need a 16px version of this or only the 24px?

from octicons-v2.

@edokoa I like the first and the third columns (from the left). Also, it appears that 24px might be the only size used atm but I do think we should consider what solution we might provide for a 16px icon too.

@jasonlong is the internal-repo icon used in a smaller context anywhere else?

from octicons-v2.

I just wanted to add another version I thought about after posting this, the inverted variation of the 4th

I think it makes it stand out more from the rest.

from octicons-v2.

@jasonlong Does internal-repo mean "internal to an enterprise" in general or "internal to github" specifically?

from octicons-v2.

👋🏽friendly bump from iam as we currently are hardcoding the SVG in :repo/settings/access which happens to render badly in Safari github/github#133353

@CamiloGarciaLaRotta @jasonlong https://github.com/primer/octicons/blob/master/CHANGELOG.md#950

from octicons-v2.

Source is in https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=876%3A297

from octicons-v2.

@colebemis should we add using the 16px repo icon for the current internal-repo icon to the list of re-mapping? I'm not sure if @jasonlong and @CamiloGarciaLaRotta might have additional work on their end to reposition and resize the org avatar for this.

from octicons-v2.

but running locally yields a runtime error, I believe the octicon is not yet available in the bundled version of the monolith. Should I wait for the team to officially bump the octicon version in the monolith?

@colebemis I thought we added this 🤔

Did we not push the release?

from octicons-v2.

Yeah we'll need to coordinate the rollout of the new icon since the avatar has custom absolutely positioned coordinates.

from octicons-v2.