Comments (5)
@JoshBowdenConcepts exactly. Because it performs an action and doesn't lead to another URL.
![image](https://private-user-images.githubusercontent.com/3661203/237616859-b2b2888a-ec9c-48f4-9d26-087f1faa9c3b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNTM5NDgsIm5iZiI6MTcyNTE1MzY0OCwicGF0aCI6Ii8zNjYxMjAzLzIzNzYxNjg1OS1iMmIyODg4YS1lYzljLTQ4ZjQtOWQyNi0wODdmMWZhYTljM2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDFUMDEyMDQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9N2JjMWE1OTkxYzZhZGZlODlhYTQwZmE0ZTAwZWMwMzUwOWQxM2RjNWJiZWU4MmY4ZDEwNDFjMDE4ODk2YTliNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.qNEt-PsQIj2tS9tjSsTkx1BTGzsFqH-44vCXRJ4D2dE)
from brand.
Potential solution:
Enable as
prop of type a | button
for MinimalFooter.Link, similar to other polymorphic components in Primer Brand.
from brand.
Works for me, but the button
wouldn't have the href
attribute.
from brand.
Works for me, but the
button
wouldn't have thehref
attribute.
👍 We'll handle that using conditional types
from brand.
Just to clarify here! Is the intention for this content to be a Button but look like a Link, as you have shown on the Enterprise page?
from brand.
Related Issues (20)
- [Feature Request] Add support for passing additional data attributes to pagination links HOT 1
- [Feature Request] Add ability to attach analytics attributes to FAQ tab buttons HOT 1
- [Feature request] Extend the max-width of the Hero Component's H1 HOT 4
- [Feature request] Story scroll river HOT 3
- Links to Storybook from docs site don't work locally
- Inconsistent page layout in docs HOT 5
- 🐛 [BUG] - Image aspectRatio prop is not applied to the Image component HOT 1
- 🐛 [BUG] - Advice: Animation impacting Contentful Paint performance for SEO Article page HOT 2
- Anchor links for `FAQ` Questions HOT 1
- [Suggestion] Expand link area of `SubdomainNavBar`
- 🐛 [BUG] - Misalignment of icons in FormControl.Validation HOT 1
- 🐛 [BUG] - Focus outline on fullWidth Select component doesn't fill entire width
- Improve Storybook quality - remove inconsistencies and add missing content HOT 4
- [Suggestion] Improve anchor link support on mobile in `SubdomainNavBar` HOT 3
- 🐛 [BUG] - Select component does not forward the name prop/attribute value
- Errors in CTABanner documentation
- [Feature request] Specs pricing table HOT 1
- [modification request] table styling in Prose HOT 3
- Update River interface guidelines to disallow button usage
- [modification request] Add pause button to Logobar
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brand.