Comments (6)
@melloware Do I understand correctly, that after this PR fix I can create a link with passed href
to my <PrimeButton />
component?
from primereact.
I have to study the code and see what PrimeTek original intent of this and what PrimeVue is doing. But right now this code does not look like it is doing as it was intended.
from primereact.
What specific changes or enhancements are you aiming to make to the button component in your application, particularly in terms of its appearance and functionality? The showcase seems fine to me can you be more elaborate?
from primereact.
@galimovkirill i think this is just confusion over what you want to do and I just updated the docs. There are 3 scenarios.
Button Rendered As Link
This renders the buttons as Link and navigates you to https://react.dev
on Click.
<Button label="Link" link onClick={() => window.open('https://react.dev', '_blank')} />
Link Rendered as Button
This is a normal HTML link that just is "styled" to look like a button
<a href="https://react.dev" target="_blank" rel="noopener noreferrer" className="p-button font-bold">
Navigate
</a>
What you want is something more like this....
Button pretending to be a Link
This is a normal button with all the behaviors like "disabled" etc it just simply performs a navigation.
// open a new URL
<Button label="Open URL" link onClick={() => window.open('https://react.dev', '_blank')} />
// use NextJS Router to go to another URL
<Button label="Navigate In App" link onClick={() => router.push('/desired-url');} />
```
from primereact.
I think that current button implementation cannot provide functionality for my needs.
I meant that I need normal HTML link which looks like button without setting any additional classes.
You can see example at MUI's component: https://mui.com/material-ui/react-button/#text-button
The 3rd button is a link, but we render it with <Button/>
component and can pass any prop like variant
to change styling of button (which is link actually). So, just because we pass href
prop, it decide itself that it should render specific HTML tag.
from primereact.
@galimovkirill yes the equivalent in PR.
MUI:
<Button href="#text-buttons">Link</Button>
PR:
<Button label="Open URL" link onClick={() => window.location.hash = "#text-buttons";} />
from primereact.
Related Issues (20)
- DataTable: rowReorder not displaying "ghost" row when dragging HOT 10
- DataTable: Advanced Column Filter 'Match Mode' Dropdowns Are Broken in 10.6.4 HOT 3
- Calendar: with showTime and dateFormat, input field doesn't work HOT 5
- Datatable: using rowsPerPageOptions produces error when clicked HOT 2
- Calendar: Range selectionMode does not allow multi-year (month?) HOT 11
- Missing PT Option for IconField in Password HOT 13
- ListBox Group: Keyboard navigation functions wrong HOT 1
- Calendar - viewDate props - event is null HOT 3
- DataTable: Dynamic column and static column duplicate static column on reorder HOT 6
- Dropdown, Dialog: Blank dropdown when using an array of primary values HOT 13
- Dialog: onHide Called Twice HOT 1
- FontAwesome: Typescript issue passing props HOT 5
- Password: ToggleMask overwrite input width HOT 1
- DataTable: Autocomplete with Dialog on cell editing is not working HOT 3
- DropDown with Groups HOT 3
- InputOTP: Keyboard shortcut paste not working in IntegerOnly HOT 1
- DataTable > Column: It doesn't show operators dropdown and value input when dynamic column is in-place. HOT 1
- AutoComplete Input Passthrough not passing through HOT 4
- Menu: The first item remain focused even after clicking on another item. HOT 3
- Dropdown: Simple primitive values showing empty items HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from primereact.