Giter Club home page Giter Club logo

Comments (7)

melloware avatar melloware commented on August 27, 2024

Actually accordiontab is right and tab is wrong. Let me fix.

from primereact.

melloware avatar melloware commented on August 27, 2024

PR submitted

from primereact.

nrueckmann avatar nrueckmann commented on August 27, 2024

Thx, but it looks like your PR does not touch the type definitions which should be adjusted as well.

from primereact.

melloware avatar melloware commented on August 27, 2024

Which type defs do you refer?

from primereact.

nrueckmann avatar nrueckmann commented on August 27, 2024

If i understand your PR right, you just changed the name of the field from tab to accordiontab. My initial issue was a different story:

PrimeReactPTOptions says it has a accordiontab field, but using it does not work.
AccordionPassThroughOptions says it does not have a tab or accordiontab field, but using it does work.

So the following documentation does not match the types:

const Tailwind = {  
    accordion: {
        root: 'mb-1',
        tab: {} // this field is not valid as AccordionPassThroughOptions does not have a field `tab` or `accordiontab`
    }
}

from primereact.

melloware avatar melloware commented on August 27, 2024

Yep it looks like tab/accordiontab has always been missing. Let me update.

from primereact.

melloware avatar melloware commented on August 27, 2024

OK updated my PR.

from primereact.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.