Giter Club home page Giter Club logo

Comments (13)

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
Mistake: that was since r136 that nfc-mftool try to read MIFARE Classic using
defaults key.

Original comment by [email protected] on 20 Oct 2009 at 4:01

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
. => OK
x => wrong
(writing (OK) data to file : ...)

Do you have any suggestions to make this more readable ?:)

Original comment by [email protected] on 31 Oct 2009 at 1:43

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
Yes Roel: like previously said: "If crosses are failures, we shouldn't have a 
"Done,
all bytes dumped to file!" message." isn't it ?

Original comment by [email protected] on 2 Nov 2009 at 8:21

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
Agreed, let's get rid of the stupid message ;)

Original comment by [email protected] on 3 Nov 2009 at 1:40

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
NOTE: This patch is not tested!

Original comment by emanuele.bertoldi on 19 Nov 2009 at 10:33

Attachments:

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
how it works this patch?

Original comment by [email protected] on 20 Nov 2009 at 3:44

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
At first sight, this patch contains one error: switching from signed to unsigned
integer deny to be below under 0...so please don't use this patch if you don't 
know
how to fix it.

Original comment by [email protected] on 20 Nov 2009 at 4:05

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
Well, there is another typo error: "print_success_of_failure" instead of
"print_success_or_failure".

For the un/signed problem, simply don't change the "iBlock" variable. But why 
we need
a signed counter?

Original comment by emanuele.bertoldi on 20 Nov 2009 at 4:22

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
This is a better version.

Original comment by emanuele.bertoldi on 20 Nov 2009 at 5:09

Attachments:

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
Zuck> For the un/signed problem, simply don't change the "iBlock" variable. But 
why
we need a signed counter?

If you check the for-loop:
> for (iBlock=uiBlocks; iBlock>=0; iBlock--)
You can see that for-loop will loop until iBlock < 0. And iBlock can't be 
negative if
it's unsigned.

BTW, thanks for patch. I will try to commit them in trunk on Monday 23th.

Original comment by [email protected] on 20 Nov 2009 at 6:21

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
Romuald, this is clear, but that is the only signed counter in "classic" and
"ultralight" tools. Why we can't simply switch to an unsigned one and change the
guard condition?

Please, correct the typo error when you merge it to the trunk ;)

Original comment by emanuele.bertoldi on 23 Nov 2009 at 10:27

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024
Patch have been applied in r212. Thanks you Zuck.

Original comment by [email protected] on 27 Nov 2009 at 4:53

  • Changed title: nfc-mfclassic's output should be more clear

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 23, 2024

Original comment by [email protected] on 27 Nov 2009 at 4:53

  • Changed state: Fixed

from libnfc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.