Giter Club home page Giter Club logo

Comments (15)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024

Original comment by [email protected] on 30 Sep 2009 at 9:58

  • Changed state: New

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
What do you think about:
 - add "_t" suffix to types (defined using typedef), 
 - append "nfc_" prefix, IMHO it should be cleaner.
 - found a self-explained name for struct and typedef

i.e.:
 - init_modulation => nfc_modulation_t
 - dev_info => nfc_device_t
 - etc.

Original comment by [email protected] on 21 Oct 2009 at 3:18

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
In my opinion the "nfc_device" terminology is ambiguous because it's not clear 
if a
device is the user NFC chip or a third party NFC active device.

Original comment by emanuele.bertoldi on 28 Oct 2009 at 9:50

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
Fine Zuck, what do you purpose ?

Original comment by [email protected] on 28 Oct 2009 at 10:50

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
Could "nfc_adaptor_t" be a good option?

Original comment by emanuele.bertoldi on 30 Oct 2009 at 2:02

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
These two sound nice:
 - init_modulation => nfc_modulation_t
 - dev_info => nfc_adaptor_t

I will try to look into the init_modulation_t struct. It should be a straight 
forward
usable syntax.

Original comment by [email protected] on 31 Oct 2009 at 1:40

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
Remember to change "nfc_device_desc_t" too:

nfc_device_desc_t => nfc_adaptor_desc_t

Original comment by emanuele.bertoldi on 2 Nov 2009 at 9:38

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
init_modulation => nfc_modulation_t
is not correct.... since talk about the "initial modulation" (for 
anti-collision)
later you can boost up the speed (change modulation). This is not (yet) 
supported,
but the initial modulation will never change... (for example for a ISO14443-A 
card)

Original comment by [email protected] on 3 Nov 2009 at 1:55

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
so it sould be then ?:)
init_modulation => nfc_init_modulation_t

Original comment by [email protected] on 3 Nov 2009 at 1:56

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
Yes, I think you're right.

Original comment by emanuele.bertoldi on 3 Nov 2009 at 3:03

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
Roel, if I understand correctly, I'm not agree with you on this point, a typedef
define a type, the nature of described thing. "initial modulation" is a 
modulation,
of course when I read your comment I understand there is a "current modulation" 
and
an "init modulation" but that seems to be variables roles, not types. I think we
should have a nfc_modulation_t type which can be ISO14443A_106, FELICA_212, 
etc. and
two variables nmInitModulation and nmCurrentModulation in the right structure.
Did I misunderstood something ?

Original comment by [email protected] on 5 Nov 2009 at 2:53

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024

Original comment by [email protected] on 14 Jan 2010 at 4:52

  • Removed labels: Milestone-1.3.0

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024

Original comment by [email protected] on 3 Feb 2010 at 3:12

  • Added labels: Milestone-1.4.x

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024

Original comment by [email protected] on 21 Apr 2010 at 1:17

  • Added labels: OpSys-All

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
The main idea of this issue is now fixed since r452.

Original comment by [email protected] on 22 Jul 2010 at 2:26

  • Changed state: Fixed

from libnfc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.