Comments (15)
Original comment by [email protected]
on 30 Sep 2009 at 9:58
- Changed state: New
from libnfc.
What do you think about:
- add "_t" suffix to types (defined using typedef),
- append "nfc_" prefix, IMHO it should be cleaner.
- found a self-explained name for struct and typedef
i.e.:
- init_modulation => nfc_modulation_t
- dev_info => nfc_device_t
- etc.
Original comment by [email protected]
on 21 Oct 2009 at 3:18
from libnfc.
In my opinion the "nfc_device" terminology is ambiguous because it's not clear
if a
device is the user NFC chip or a third party NFC active device.
Original comment by emanuele.bertoldi
on 28 Oct 2009 at 9:50
from libnfc.
Fine Zuck, what do you purpose ?
Original comment by [email protected]
on 28 Oct 2009 at 10:50
from libnfc.
Could "nfc_adaptor_t" be a good option?
Original comment by emanuele.bertoldi
on 30 Oct 2009 at 2:02
from libnfc.
These two sound nice:
- init_modulation => nfc_modulation_t
- dev_info => nfc_adaptor_t
I will try to look into the init_modulation_t struct. It should be a straight
forward
usable syntax.
Original comment by [email protected]
on 31 Oct 2009 at 1:40
from libnfc.
Remember to change "nfc_device_desc_t" too:
nfc_device_desc_t => nfc_adaptor_desc_t
Original comment by emanuele.bertoldi
on 2 Nov 2009 at 9:38
from libnfc.
init_modulation => nfc_modulation_t
is not correct.... since talk about the "initial modulation" (for
anti-collision)
later you can boost up the speed (change modulation). This is not (yet)
supported,
but the initial modulation will never change... (for example for a ISO14443-A
card)
Original comment by [email protected]
on 3 Nov 2009 at 1:55
from libnfc.
so it sould be then ?:)
init_modulation => nfc_init_modulation_t
Original comment by [email protected]
on 3 Nov 2009 at 1:56
from libnfc.
Yes, I think you're right.
Original comment by emanuele.bertoldi
on 3 Nov 2009 at 3:03
from libnfc.
Roel, if I understand correctly, I'm not agree with you on this point, a typedef
define a type, the nature of described thing. "initial modulation" is a
modulation,
of course when I read your comment I understand there is a "current modulation"
and
an "init modulation" but that seems to be variables roles, not types. I think we
should have a nfc_modulation_t type which can be ISO14443A_106, FELICA_212,
etc. and
two variables nmInitModulation and nmCurrentModulation in the right structure.
Did I misunderstood something ?
Original comment by [email protected]
on 5 Nov 2009 at 2:53
from libnfc.
Original comment by [email protected]
on 14 Jan 2010 at 4:52
- Removed labels: Milestone-1.3.0
from libnfc.
Original comment by [email protected]
on 3 Feb 2010 at 3:12
- Added labels: Milestone-1.4.x
from libnfc.
Original comment by [email protected]
on 21 Apr 2010 at 1:17
- Added labels: OpSys-All
from libnfc.
The main idea of this issue is now fixed since r452.
Original comment by [email protected]
on 22 Jul 2010 at 2:26
- Changed state: Fixed
from libnfc.
Related Issues (20)
- SAK value problem HOT 1
- P2P using NDEP example fails on to DeSelect HOT 1
- No NFC device found on Intel Ultrabook HOT 6
- Support higher speeds for Type A tags HOT 1
- Add cmake config files HOT 1
- Timeout SCL3711 mfoc HOT 2
- list HOT 1
- error libnfc.chip.pn53x Unexpected PN53x reply!
- ./configure --with-drivers=pn532_uart --sysconfdir=/etc --prefix=/usr HOT 5
- Wrong open mode for file descriptor 4 in utils/nfc-relay-picc.c
- cmake soversion doesn't match autotools
- nfc-mfsetuid: Write complete Block0, instead of onle UID
- I am new to libnfc stuff , could anyone provide me with some links where I can learn more about implementing libnfc on raspberry pi? thank you in advance
- Invalid RDR_to_PC_DataBlock frame with ACR122U HOT 1
- Support for ACS ACR1251U Reader HOT 1
- udev rule is executed to early
- libnfc tries to access a smartcard reader HOT 2
- Patch for compilating under Cygwin HOT 1
- PN532 frame preamble parsing shortcoming
- libnfc is now officially on GitHub
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libnfc.