Giter Club home page Giter Club logo

Comments (5)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
Why don't you re-design the entire source tree instead?

- src

-- core

--- links
---- usb
---- uart
---- i2c
---- spi

--- chips
---- pn531
---- pn532
---- pn533

--- devices
---- arygon
---- ...

--- libnfc.h
--- libnfc.c

-- tools
--- nfc-list
--- nfc-anticol
--- ...

Original comment by emanuele.bertoldi on 2 Oct 2009 at 10:55

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
Roel, I'm agree with your point of view: we must get a better overview.

Zuck, we can't redesign like you describe due to actual structure of libnfc: for
example we haven't both abstractions: chips and devices. BTW, we could restruct 
a bit
like that:

+-+ src
  |
  +- libnfc.c
  +- libnfc.h
  |
  +-+ nfc
  | +- bitutils.h/c
  | +- defines.h
  | +- types.h
  | +- ...
  |
  +-+ devices
  | +- pn531_usb.h/c
  | +- pn533_usb.h/c
  | +- pn532_uart.h/c
  | +- arygon_uart.h/c
  |
  +-+ examples
    +- nfc-mftool
    +- nfc-mfultool
    +- nfc-list
    +- nfc-anticol
    +- ...

What do you think about Roel ? Zuck ? other contributor/developer ?

Original comment by [email protected] on 5 Oct 2009 at 3:13

  • Changed title: Rename source files for executables (examples) to nfc-*.c
  • Added labels: Priority-Low, Milestone-1.3.0
  • Removed labels: Priority-Medium

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
I like that structure Romuald, "pn531_usb.h/c" and "pn533_usb.h/c" could become
"pn53x_usb.h/c" (just the same for the uart), but hey, that is a other issue we 
are
going to solve soon ;)

One thing though, is "nfc" maybe a to vague topic to put all those files under?
Maybe "general" or "core" or "support", or just "various"

Well, anyway, I think it looks nice and clean the proposed way!

Original comment by [email protected] on 5 Oct 2009 at 8:56

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024

Original comment by [email protected] on 6 Oct 2009 at 8:31

  • Changed state: Started

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 24, 2024
Renaming task have been done in r140 and examples sources have been put in
src/examples subdirectory.

Original comment by [email protected] on 6 Oct 2009 at 8:35

  • Changed state: Fixed

from libnfc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.