Giter Club home page Giter Club logo

Comments (7)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
Thanks for report and solution.
r90 should fix this issue, code review wanted.

Regarding tools that use some bitutils.h functions, that's not a libbitutils but
libnfc :-), so theses tools should not use theses functions, or theses functions
should be macros.

Original comment by [email protected] on 3 Sep 2009 at 3:28

  • Changed state: Fixed

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
Well, but they do. And they become part of libnfc at compile time of course. 
Attached 
patch fixes Windows building and adds the exports which are required by some 
tools. I 
wish they weren't needed :-)

Windows does not have usleep, but needs Sleep instead. 

Original comment by fkooman%[email protected] on 3 Sep 2009 at 6:00

Attachments:

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
And what about wanting to use C++ on Windows? This is not taken care of by your 
approach? 

I'm playing way too much with Windows! I don't even use it...

Original comment by fkooman%[email protected] on 3 Sep 2009 at 6:01

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
Hey Fkooman,
Patch have been applied in r92, r93 and r94. Thank you.

About wanting to use C++ on Windows, it seems that "__cplusplus" is also 
defined by
Windows C++ compilers (according to web search), so LIBNFC_EXPORT will put 
"extern
"C"" as expected. But maybe Windows C++ compiler needs specific code ?

Original comment by [email protected] on 4 Sep 2009 at 9:04

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
My point was that what if you need both the DLL exports and the C++ extern "C" 
thingy. 

I don't pretend to understand how it works for C++, but it is needed in front 
of all
functions as well? So now you can either have DLL exports or C++ support...

Original comment by fkooman%[email protected] on 4 Sep 2009 at 9:34

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
Can you have a look at r97: considering your point, I had try to handle 
LIBNFC_EXPORT
define another way.

Original comment by [email protected] on 4 Sep 2009 at 2:06

  • Added labels: OpSys-Windows

from libnfc.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 29, 2024
That seems nice! Although I have no way of testing this with C++ apps, maybe 
the dude
of Issue 16 can confirm this. Maybe reopen his issue until he confirms fixed.

Original comment by fkooman%[email protected] on 4 Sep 2009 at 9:03

from libnfc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.