Comments (6)
Comments are probably where most of the subtle bugs are right now. They're pretty difficult to get right, but this is definitely problematic. I think it'll take a few weeks to sort out these kinds of bugs, but we'll get there.
from prettier.
prettier sure doesn't know what to make of ASCII art that is laid out to the right of the real code, such as this example (input):
// 60 chars --> |
function makeComponent(): int {
return { // (__)
longCall() { // (oo)
complicatedFunction( // /------\/
importantArgument(), // / | ||
secondaryArgument() // * /\---/\
); // ~~ ~~
weirdStyle({ prop: 1 }, 1, 2, 3);
},
render() {
const user = { name: "James" };
return (
<div>
hello ${name}! JSX is<strong>supported</strong>
</div>
);
}
};
}
but honestly I don't know what you do with devs who insist on that sort of thing; tell them to cut it out I suppose.
from prettier.
@jepler I've seen a few cases where someone had some sort of diagram / flowchart which was important but I would think a reasonable position would simply be “Make it a full multi-line comment block”.
from prettier.
inline comments in all positions are extremely difficult. The case where there inline comments beside function call arguments is a known issue in recast as well, and it actually reclassifies those comments as leading comments (moves them up before the expression). I think right now we copy that behavior sometimes too.
But yes, there are going to be times where there is only so much we can do, and users need to change how they write a specific style so that it formats better. We can make inline comments better to some degree, but I'm not sure how far we can go.
from prettier.
This one is a rather big issue for me, I tend to use the space to the right for a comment whenever it helps, such as to say what that object property is or what have you
from prettier.
See above PR
from prettier.
Related Issues (20)
- `pre-commit` mirror continued support for version 3 after `v3.1.0` HOT 3
- Number list confusion with heading after bullet list
- Preserve HTML attribute wrapping like the default formatter "html.format.wrapAttributes": "preserve"
- Typescript regression in handling functions with generic types and method chaingin in 3.2.0 compared to 3.1.0 HOT 1
- Second format failed when running next lint. Rule: "prettier/prettier" HOT 2
- Extension 'Prettier - Code formatter' is configured as formatter but it cannot format 'Svelte'-files HOT 1
- Markdown Parser double spaces lists with code that has spaces
- TypeError: join(...).filter is not a function
- TypeError: prettierApi.getFileInfo.sync is not a function
- TypeError: prettierApi.getFileInfo.sync is not a function HOT 1
- Same configurations but different document format display HOT 1
- Formatting of embedded equations in Markdown is sometimes incorrectly escaping underscores
- Formatting can break `/*#__PURE__*/` annotations HOT 1
- Issues with prettier-vscode not working properly with plugins since prettier 3.1.0 release HOT 8
- JSX empty lines are removed
- File names with dollar sign ($) in the name cannot be processed by Prettier
- Typescript 5 const modifier on type parameters leads to SyntaxError HOT 1
- Simple template literal should break at all interpolations instead of exceeding the max line width HOT 6
- ENAMETOOLONG error when running prettier HOT 1
- [Feature Request] Add support for TS config files (`prettier.config.ts`) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prettier.