Comments (6)
Here, IMO the best style would be the one that optimizes for diff readability on changes.
Like the one in the OP post.
Probably worth doing for any elements that don't fit within a single line completely.
from prettier.
And don't forget about this form:
const FooForm = ({colour}) => {
const method = 'GET'
return (
<BaseForm {...{
url: '/auth/google',
method, colour
}}/>
)
}
from prettier.
Similarly, I tested:
const render = ({ styles }) => (
<div style={styles} key="something">
Keep the wrapping params. Put each key on it's own line.
</div>
);
which results in:
const render = ({ styles }) => <div style={
styles
} key="something">
Keep the wrapping params. Put each key on it's own line.
</div>;
from prettier.
I'm going to try to tackle this now.
from prettier.
The example by @ericclemmons now compiles to:
const render = ({ styles }) => <div style={styles} key="something">
Keep the wrapping params. Put each key on it's own line.
</div>;
which is an improvement, but I agree the parens should be maintained. I'll open a separate issue for that if one doesn't already exist, and try to tackle soon.
(note that improvement is probably unrelated to my modification, I didn't check)
from prettier.
I am closing this in favour of #73. Please continue the discussion in that thread.
from prettier.
Related Issues (20)
- prettier formatWithCursor very slowed when use with *.min.js HOT 1
- [CSS] Remove extra indent for multiline `:where`, `:is` and `:not` selectors
- Ranged formatting for `yield` in iterators breaks with tuples HOT 1
- Ugly logical expression break in Vue `v-if`
- [bug] [yaml] list indent fix can result in invalid yaml or change the meaning of existing yaml
- HTML 'strict' whitespace sometimes injecting a '>'
- Bug with type assertion around yield expression
- Prettier breaks Markdown alert syntax
- Prettier changes meaning of HTML+JS code when using tags that look like self-closing HOT 3
- Comment in last line of YAML files gets leading newline trimmed HOT 1
- Typescript: Prettier incorrectly breaks up constructor properties from modifiers when there is a decorator and comment before it HOT 1
- [Documentation] Pre-Commit Hook Usage case caveat
- Still the error "Error: Comment "Hello" was not printed. Please report this error!" even though I have added a comment in the Doc. HOT 1
- [JavaScript] Comments between ternary operator formatting result is ugly HOT 2
- Prettier wrong formatting of Angular flow HOT 3
- Markdown undesirable formatting behaviour when new text added to paragraph HOT 2
- Error when file names HOT 4
- Can we have a CLI flag that allows ignoring .gitignore and/or .prettierignore please? HOT 2
- Unstable block comment for implemented interfaces (TypeScript) (moved and non-idempotent)
- Markdown lists with extra indent lead to unstable formatting behavior
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prettier.