Giter Club home page Giter Club logo

Comments (11)

mickaelandrieu avatar mickaelandrieu commented on May 28, 2024 3

Basically, if a PS dev could knock up a quick module for us to download (Described above) it will answer 100's of questions in one go

You may find some resources here: https://github.com/friends-of-prestashop

But IMHO, it shouldn't be us (ie the PrestaShop company) but you the developers that should improve the documentation according to your needs and create this kind of skeletons 👍. We give you tools and you are free to adapt them to provide value to your customers, including creating your own skeletons that speed up your future developments!

Currently from the dev docs it looks like we need to work in "src/PrestaShopBundle..."

We never say in the docs that people have to work in src/: would you mind to share with us where did you find such (wrong) advice?

I won't close this as a community member may help you: after all, this is how open source and community projects work 😄

Ping @ttoine, how about a new label "Waiting for a Community Member"?

from docs.

sarjon avatar sarjon commented on May 28, 2024 1

hi @Bossman1337 this module https://github.com/Invertus/ps-training may be interesting for you. It shows some features of Symfony in modules (services, routes, dependency injection, unit tests, controllers, forms, twig & etc).

from docs.

frederic-benoist avatar frederic-benoist commented on May 28, 2024 1

Hi,

I have put online some modules used during prestashop training.
You can find them on my github account.

For the moment, the most interesting modules are only available during the training sessions. They should be posted online after the training materials have been updated.

from docs.

matks avatar matks commented on May 28, 2024 1

Hi, we have a released a demo module for 1.7.6 that uses:

  • new grid (listing pages) hooks
  • new identifiable object form (add/edit pages) hooks

This should cover a lot of your questions 😄

https://github.com/friends-of-prestashop/demo-cqrs-hooks-usage-module/

from docs.

Bossman1337 avatar Bossman1337 commented on May 28, 2024

@mickaelandrieu

But IMHO, it shouldn't be us (ie the PrestaShop company) but you the developers that should improve the documentation according to your needs and create this kind of skeletons 👍. We give you tools and you are free to adapt them to provide value to your customers, including creating your own skeletons that speed up your future developments!

I disagree with this statement. its like the chicken or egg question. How am i supposed to develop and improve the documentation if i don't know how to do it in the first place. PS is all about best practices etc. Take Symfony's documentation for example, this is exemplary and tonnes of it too with many examples.
If you Google anything regarding PS, it is very difficult to find anything up to date and is full of people just overriding instead of using hooks correctly. Trying to find anything regarding modern pages/modules is nonexistent.
Basically you're saying "Just look through all our code and work it out for yourself". You might like to work inefficiently, but we don't.

My next question to you would be: Can you or can't you create a "Modern module" like i described?

We never say in the docs that people have to work in src/: would you mind to share with us where did you find such (wrong) advice?

Here: https://devdocs.prestashop.com/1.7/development/architecture/understanding-src-folder/
Here: https://devdocs.prestashop.com/1.7/development/architecture/migration-guide/ (the majority of the migration guide references the src.. folder) Its confusing tbh.

If you or any other dev that knows PS inside out, can create a module that i described then i'll create the documentation for it.

from docs.

Bossman1337 avatar Bossman1337 commented on May 28, 2024

@sarjon thanks for that, i will have a look. It still throws a lot of questions without commented code or documentation. Still think we need a module we can download and install, so we know it's complete and works.

Looks good though, i will pursue this and see if i can create anything from it, then i will create documentation for it.

from docs.

mickaelandrieu avatar mickaelandrieu commented on May 28, 2024

Take Symfony's documentation for example, this is exemplary and tonnes of it too with many examples.

I can tell - as one of the contributors of the Symfony documentation - that this is mostly contributed by external contributors. You can see that when a community work together the result is great!

If you Google anything regarding PS, it is very difficult to find anything up to date and is full of people just overriding instead of using hooks correctly.

I agree with you on this point: why PrestaShop developers don't share their knowledge with the community? I'm initially from the Symfony community (ex-SensioLabs employee, Symfony contributor, etc) and it's still a mystery for me. But a company "alone" can't create so many resources, not in a business model when our project is delivered for free to people.

Here: https://devdocs.prestashop.com/1.7/development/architecture/understanding-src-folder/
Here: https://devdocs.prestashop.com/1.7/development/architecture/migration-guide/ (the majority of > the migration guide references the src.. folder) Its confusing tbh.

The links you have visited are about the understanding of the complete architecture of PrestaShop and how people can help us to migrate the Back Office to Symfony, you will find information about the creation of modules in the module part of the documentation: https://devdocs.prestashop.com/1.7/modules/

By the way, if you want to help with the Symfony migration, you can ping @matks and/or @sarjon: we love contributors :)

hi @Bossman1337 this module https://github.com/Invertus/ps-training may be interesting for you.

Thanks, @sarjon for sharing! Can I fork your repository to put it into the Friends of PrestaShop organization? At some point, we could also accept it into the PrestaShop organization, but the core team won't have the time to maintain it so... ping @eternoendless

I've just pushed a new module customers into the organization, but what is/are missing here is people writing articles, explaining what they have tested and learned, and able to contribute to the documentation.

We (the Core team) invest already a lot of resources into the documentation and the tests, but we won't be able to do all the work alone, we need all of you 👍

from docs.

sarjon avatar sarjon commented on May 28, 2024

Can I fork your repository to put it into the Friends of PrestaShop organization

sure, it's open source. 👍 we could create some example module that does something useful with well commented code.

from docs.

Bossman1337 avatar Bossman1337 commented on May 28, 2024

@mickaelandrieu

I'm looking over @sarjon module now. I think ultimately we need "Modern Modules" in the dev docs, the link you gave is for legacy module creation. I've created many modules this way and are fine. But as PS is going through a limbo period migrating to Symfony with only a few admin pages built with Symfony this https://devdocs.prestashop.com/1.7/modules/ doesn't explain database saving with Doctrine for example.

from docs.

mickaelandrieu avatar mickaelandrieu commented on May 28, 2024

Note that I'm not against 1 page in the docs with a list of links about interesting modules, but I'm against "one more" module to be maintained by the Core team. We already maintain a lot (look at the number of active repositories in the PrestaShop organization: crazy, right?).

More, I repeat myself maybe, but I think that PrestaShop developers are more relevant to decide which "modern module" architecture is the best for their needs.

Of course, we will support any efforts 👍

Thanks for sharing @frederic-benoist !

from docs.

matks avatar matks commented on May 28, 2024

Closing the issue as I think https://github.com/friends-of-prestashop/demo-cqrs-hooks-usage-module is answering this need.

Feel free to open a new issue if there are topics uncovered 😉

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.