It would be great if I could build my own sitemap generator and use that instead of th

Hello, Look in <a href="https://github.com/prestaconcept/PrestaSitem

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

This will be done in the next major release. See <a class="issue-link js-issue-link" d

Allow a custom generator service about prestasitemapbundle HOT 5 CLOSED

prestaconcept commented on July 17, 2024

Allow a custom generator service

from prestasitemapbundle.

Comments (5)

halundraN commented on July 17, 2024

Hello,

Look in https://github.com/prestaconcept/PrestaSitemapBundle/blob/master/Resources/config/services.xml, the presta_sitemap.generator service class is defined as a parameter: presta_sitemap.generator.class then you can already configure it and use your own generator.

But I'm agree, the current generator extends from an abstract class and it would be better to formalize it with an GeneratorInterface.

Maybe can you do a PR for this?

from prestasitemapbundle.

jvandesande commented on July 17, 2024

@alain-flaus I know that I can overwrite the parameter, but it doesn't allow me to add my own arguments to the constructor.

I will look into a PR as soon as I need it again.

from prestasitemapbundle.

yann-eugone commented on July 17, 2024

@jvandesande : the .class parameters will be removed in the next release, as Symfony did some time ago. If you want to replace the service, you can do it using a CompilerPass.
Still, I thing this is a good enhancement.

from prestasitemapbundle.

yann-eugone commented on July 17, 2024

This will be done in the next major release. See #92.
I'm closing this issue.

from prestasitemapbundle.

jvandesande commented on July 17, 2024

Thanks

from prestasitemapbundle.

Recommend Projects