Giter Club home page Giter Club logo

Comments (10)

mente avatar mente commented on September 18, 2024

Not sure about apache, but nginx supports gzip compression of the content on the fly. Even for fastcgi backends.
So what's the point of this issue?

from prestasitemapbundle.

Koc avatar Koc commented on September 18, 2024
  1. imho we should return sitemap files with corresponding extensions (xml/xml.gz).
  2. when we have 120+ subdomains (100Mb+ sitemaps per domain) - it could be a problem to store them. So it would be nice if dumper allow gzipping

from prestasitemapbundle.

mente avatar mente commented on September 18, 2024

100Mb+ is a problem to store only on $5 shared hosting. Ancient browsers do not support gzip encoding. Let http servers solve such problems.

from prestasitemapbundle.

Koc avatar Koc commented on September 18, 2024

Леша, причем тут браузеры? С каких это пор мы делаем сайтмапы для людей? Я говорю, что у нас 120 субдоменов, у каждого по 100 с лишним карт сайтов. Зачем занимать столько места если можно все это сжать?

from prestasitemapbundle.

iamdey avatar iamdey commented on September 18, 2024

gni?!
(Don't worry I used google translate. Please don't forget to use english).

from prestasitemapbundle.

mente avatar mente commented on September 18, 2024

@Koc stick to english, this is international resource. Let me explain my last comment: you can not guarantee gzip support for any client. Neither browser, neither google bot, neither any other crawler. Gzip support is a big problem for any 3rd party library: there's zlib library but it's not enabled by default. It's possible to use gzip unix command but what about windows users? To sum up:

  • unknown support of gzip from clients
  • no easy way to use gzip in php

In the end it's open source: you need it - you fork it, you implement it. If you think it's useful for community - contribute it to upstream via push request.

P.S. Костя, don't worry, be happy

@esion i wonder what language did you use?

from prestasitemapbundle.

iamdey avatar iamdey commented on September 18, 2024

@mente I speak and think in French. Obviously it's better to communicate in English here :)

Well, about gzip I'm not sure what should be done, we don't have sitemap as large as you have.
If I well remember, the http request headers gives info about what is allowed, so we may provide an gziped answer ... or not. And as you said @mente, maybe it's the job of the http server.

For now I can't implement any solutions.

from prestasitemapbundle.

Koc avatar Koc commented on September 18, 2024

Of course this issue low priority. --gzip option would be optional. I will open PR after #28 would be merged to avoid conflicts

from prestasitemapbundle.

Koc avatar Koc commented on September 18, 2024

Also gzipping described in native specification http://www.sitemaps.org/protocol.html

from prestasitemapbundle.

mente avatar mente commented on September 18, 2024

Great! Can I peek into your code before you send a PR for it? Wondering how did you solve problems I've mentioned before

from prestasitemapbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.