Hi, If I'm willing to create a PR, would you be open to adding an op

Sure, I'm totally fine with the below for example: <div class="snippet-clipboard-c

Hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

Feature Request: Custom migration templates about goose HOT 9 CLOSED

pressly commented on May 17, 2024

Feature Request: Custom migration templates

from goose.

Comments (9)

VojtechVitek commented on May 17, 2024

Sure, I'm totally fine with the below for example:

-- +goose Up
-- +goose StatementBegin
SELECT 1;
-- +goose StatementEnd

-- +goose Down
-- +goose StatementBegin
SELECT 1;
-- +goose StatementEnd

from goose.

joelpresence commented on May 17, 2024

Thanks! Would you prefer that I allow the template to be specified as a cmdline option specifying the input template file or as an in code string passed as an arg?

…

Sent from my iPhone On May 4, 2017, at 7:43 AM, Vojtech Vitek <[email protected]<mailto:[email protected]>> wrote: Sure, I'm totally fine with the below for example:

-- +goose Up -- +goose StatementBegin SELECT 1; -- +goose StatementEnd

-- +goose Down -- +goose StatementBegin SELECT 1; -- +goose StatementEnd — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#34 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALf8WfRQ0hr6eTX1VmfA1V8QKhCp66XWks5r2eQlgaJpZM4NQNhN>.

from goose.

VojtechVitek commented on May 17, 2024

I thought you'd just change the string in the code.

I don't think it's worth passing the template via CLI - it'd be easier to create the file manually, or am I missing anything?

from goose.

joelpresence commented on May 17, 2024

Sure, changing the string in code would be even easier! I'll do that ...

Would you object to the following:

-- +goose Up
-- +goose StatementBegin
-- +goose StatementEnd

-- +goose Down
-- +goose StatementBegin
-- +goose StatementEnd

I removed the SELECT 1; because if it's in the template, people are just going to have to remove it before adding their own sql, so I'd rather just omit it if it's ok?

Thanks.

from goose.

VojtechVitek commented on May 17, 2024

go for it

from goose.

VojtechVitek commented on May 17, 2024

I think I'm gonna drop StatementBegin/StatementEnd if possible

from goose.

VojtechVitek commented on May 17, 2024

Hey @joelpresence, any update on this issue? I tried to get rid of StatementBegin/StatementEnd for good, but it's not that simple as I expected.

Note that both StatementBegin and StatementEnd are only needed when you have a advanced/complex statements containing ; within it.

We don't really need it otherwise and I tend to keep the template simple.

from goose.

eaglemoor commented on May 17, 2024

Any update?

from goose.

VojtechVitek commented on May 17, 2024

Please, go ahead and create a PR with the proposed changes. We can discuss there.

goose/create.go

Lines 61 to 88 in 58aa6a8

 var sqlMigrationTemplate = template.Must(template.New("goose.sql-migration").Parse(`-- +goose Up 

 -- SQL in this section is executed when the migration is applied. 

 -- +goose Down 

 -- SQL in this section is executed when the migration is rolled back. 

 `)) 

 var goSQLMigrationTemplate = template.Must(template.New("goose.go-migration").Parse(`package migration 

 import ( 

  "database/sql" 

  "github.com/pressly/goose" 

 ) 

 func init() { 

  goose.AddMigration(Up{{.}}, Down{{.}}) 

 } 

 func Up{{.}}(tx *sql.Tx) error { 

  // This code is executed when the migration is applied. 

  return nil 

 } 

 func Down{{.}}(tx *sql.Tx) error { 

  // This code is executed when the migration is rolled back. 

  return nil 

 } 

 `))

from goose.

Feature Request: Custom migration templates about goose HOT 9 CLOSED

Comments (9)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	var sqlMigrationTemplate = template.Must(template.New("goose.sql-migration").Parse(`-- +goose Up
	-- SQL in this section is executed when the migration is applied.

	-- +goose Down
	-- SQL in this section is executed when the migration is rolled back.
	`))

	var goSQLMigrationTemplate = template.Must(template.New("goose.go-migration").Parse(`package migration

	import (
	"database/sql"
	"github.com/pressly/goose"
	)

	func init() {
	goose.AddMigration(Up{{.}}, Down{{.}})
	}

	func Up{{.}}(tx *sql.Tx) error {
	// This code is executed when the migration is applied.
	return nil
	}

	func Down{{.}}(tx *sql.Tx) error {
	// This code is executed when the migration is rolled back.
	return nil
	}
	`))