Giter Club home page Giter Club logo

Comments (5)

kucrut avatar kucrut commented on May 17, 2024

I'm not experiencing this behaviour on my local site, both with logged-in an non-logged-in user.

from hueman.

AlxMedia avatar AlxMedia commented on May 17, 2024

Hm - let's say you have it set WordPress to show 10 top-level comments per page. Pingbacks seem to still be seen as top level comments for the comment submit button's redirect count, even if it's a separate list.

  • If you have 7 top-level comments, and 4 pingbacks, it redirects to a page-2, which has no comments, just a "previous comments" link
  • If you have 16 top-level comments and 4 pingbacks, no issue will be noticed as 16+4=20, no page change there
  • If you have 20 comments and 21 pingbacks you will be redirected 2 pages ahead and have to click "previous comments" twice to get back to the list

At least this is how I experience the issue. You can do a test comment on here, where the issue can be noticed:
http://alxmedia.se/themes/hueman/ (plenty of pingbacks)

It uses the same comments template as Hueman.

from hueman.

Gummibeer avatar Gummibeer commented on May 17, 2024

I think that the $wp_query->comments Object includes the Pingbacks. You can do it better if you use your own comment and pingback Array as that Parameter.
Ressources:
https://codex.wordpress.org/Function_Reference/get_comment_pages_count#Parameters
https://thematictheme.com/2012/06/13/improved-separation-of-comments-and-pingbacks-in-thematic-1-0-1/

I'm working on a Bugfix - I hope that this will work.

from hueman.

AlxMedia avatar AlxMedia commented on May 17, 2024

Thanks for having a look at this issue! I tested this fix on my site. I wrote the following comment in the comment box: "A friendly reminder: Use the support forums for theme support."

On comment-submit click, I am redirectecd to:
http://alxmedia.se/themes/hueman/comment-page-32/#comment-29278
The accurate link should be:
http://alxmedia.se/themes/hueman/comment-page-23/#comment-29278

It sends me to /comment-page-32/ and have to click "« Older Comments" so many times until I get to /comment-page-23/ which is the actual comments page (due to many pingbacks being counted as parent comments).

So it's not quite fixed, not sure what to do here.

from hueman.

Gummibeer avatar Gummibeer commented on May 17, 2024

Ok, I will watch it again - if I got time. It confuses me.
You can try to look at the Wordpress Themes Twenty* Don't know how they seperate Comments and Pingbacks.

from hueman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.