Comments (3)
Hi Roland, thanks for the feedback!
However, these are not false positives. Using ^
and $
is not sufficient, as they will match newlines. Once a newline is encountered, the pattern is matched, allowing an attacker to insert whatever they wish after that (or before, if ^
is used).
The Rails Security Guide has a good explanation of this issue.
from brakeman.
In Ruby, the '$' serves as an end-of-line anchor, not end-of-string. Dan Kubb wrote a gist which describes this issue pretty well:
https://gist.github.com/1444431
from brakeman.
Thanks for clearing that up.
from brakeman.
Related Issues (20)
- False Negative: warning on CSRF in Rails 5.2+ with defaults HOT 5
- Relax Rails app structure constraints HOT 2
- content_tag no longer considered dangerous HOT 1
- False positive Send where `send` is inside conditional that prevents arbitrary user input. HOT 2
- False positive for `protect_from_forgery` when defaults for rails 7 are used HOT 1
- Unscoped find not alerted for `find_by!`
- Unscoped find does not traverse concerns HOT 1
- Error: undefined method `node_type' for nil:NilClass case value.node_type HOT 4
- False positive - loofah gem 2.19.1 is already beyond suggested upgrade of 2.2.1 HOT 2
- Config in environment files generated by external services are not detected HOT 1
- Documentation Missing for Path Traversal HOT 2
- `abbrev` warning for ruby 3.4.0 HOT 4
- Possibility to ignore/skip directories/paths HOT 4
- UnsafeReflection requires array to be defined with values strictly in the context of the execution HOT 4
- Brakeman does not follow directory symlinks HOT 7
- Brakeman hangs on some platforms HOT 5
- Brakeman unable to detect Renderables in a Gem? HOT 2
- Command Injection doesn't detect shellescape unless the code is in the same function HOT 2
- Undeliverable address [email protected] in LICENSE.md HOT 2
- Controller with "log" in pathname excluded from scan HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brakeman.