Comments (3)
grosser
commented on June 2, 2024
that's just changing CI setup and does not need to be released
from premailer.
shirts
commented on June 2, 2024
I'm working on upgrading from Ruby 2.6 to 3.1 and get the below when running tests. Assumed those changes had a fix for this issue Psych is complaining about.
I pulled the latest code and changed this line to YAML::load(File.open(CLIENT_SUPPORT_FILE), aliases: true). Tests pass.
I'll dig in a little more and create a PR
job failed permanently (Psych::BadAlias: Unknown alias: border_shorthand)
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:430:in `visit_Psych_Nodes_Alias'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:345:in `block in revive_hash'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each_slice'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `revive_hash'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:167:in `visit_Psych_Nodes_Mapping'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:345:in `block in revive_hash'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each_slice'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `revive_hash'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:167:in `visit_Psych_Nodes_Mapping'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:318:in `visit_Psych_Nodes_Document'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
/Users/shirts/.rbenv/versions/3.1.0/lib/ruby/3.1.0/psych.rb:335:in `safe_load'
/Users/shirts/code/premailer/lib/premailer/premailer.rb:507:in `check_client_support'
/Users/shirts/code/premailer/lib/premailer/premailer.rb:258:in `warnings'
Edit: This was using Ruby 3.1.0, and it looks like premailer is not supported on 3.1.0 yet. My mistake.
from premailer.
grosser
commented on June 2, 2024
thx, PR welcome
from premailer.
Related Issues (20)
- Option "Do not remove wrong css styles" HOT 1
- Push latest version to RubyGems HOT 4
- Bring back yard docs / add instructions on how they are generated
- The script removal has a greedy regex HOT 1
- Minimum required ruby version HOT 1
- bgcolor attribute added with extra quotes HOT 1
- #convert_to_text misses closing `a` tag when no `href` is present but other attributes are HOT 3
- Nokogumbo has been merged into Nokogiri HOT 2
- CSS Variables HOT 7
- `bgcolor` (and probably others) should probably not be inlined HOT 2
- Direct child selector ">" is ignored HOT 3
- rule_set_exceptions option isn't respected in the nokogiri* adapters HOT 2
- Please maintain changelog HOT 1
- Two tests do not pass against Nokogiri >= 1.15.0 HOT 16
- Incorrect characters HOT 5
- Two same CSS properties on same dom element does not work HOT 1
- Slow email generation and very high CPU HOT 2
- Adapter::Nokogiri#to_inline_css raises ArgumentError with rule_set_exceptions: false HOT 5
- Two tests do not pass against Nokogiri >= 1.16.0 (libxml2 >= 2.12) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from premailer.