Giter Club home page Giter Club logo

Comments (6)

mitsuhiko avatar mitsuhiko commented on August 27, 2024 1

We could also add a starts_with filter to minijinja :)

There is a startingwith test in minijinja:

build_platform is startingwith('linux')

from rattler-build.

wolfv avatar wolfv commented on August 27, 2024

I'll take a look!

from rattler-build.

wolfv avatar wolfv commented on August 27, 2024

OK, actually there is no bug because the if: linux is for the target_platform (emscripten) and not the build_platform.

You should be able to fix the issue by using build_platform == "linux-64"

from rattler-build.

wolfv avatar wolfv commented on August 27, 2024

It's a little confusing, but it's also consistent with the rest of the recipe, so not sure what to do here. Ideas welcome!

It also makes me realize that it's not easy to check wether the build_platform is unix, or linux. Maybe we should add is_linux(build_platform), or is_unix(build_platform) functions ...

from rattler-build.

wolfv avatar wolfv commented on August 27, 2024

We could also add a starts_with filter to minijinja :)

from rattler-build.

h-vetinari avatar h-vetinari commented on August 27, 2024

OK, actually there is no bug because the if: linux is for the target_platform (emscripten) and not the build_platform.

You should be able to fix the issue by using build_platform == "linux-64"

OK, that makes sense of course! Clearly I'm not yet used to the test section having a build section as well! 😅

+1 to the other jinja enhancements too!

from rattler-build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.