Comments (6)
So should I update the PR in order to make this field not serializable ? (not visible to the outside world)
yes please
from prebid-server-java.
@jordillachmrf - please help me understand the interface impact. I see in one of your test files that there's a $.ext.usersync section of the response:
"usersync" : {
"rubicon": { "status": "expired" },
"audienceNetwork": { "status": "expired" },
"pulsepoint": { "status": "expired" },
"indexExchange": { "status": "expired" },
"lifestreet": { "status": "expired" },
"pubmatic": { "status": "expired" },
"appnexus": { "status": "expired" },
"appnexusAlias": { "status": "expired" },
"conversant": { "status": "expired" },
"conversantAlias": { "status": "expired" },
"sovrn": { "status": "expired" },
"adtelligent": { "status": "expired" },
"adform": { "status": "expired" },
"openx": { "status": "none" },
"eplanning": { "status": "expired" }
}
What is the change relating to auction result?
from prebid-server-java.
As we are filling BidResponses.ext.usersync with data then by default it'll serialized along with the rest of the object.
That's why in the PR I suggested making this field transient(or JsonIgnore), to avoid changing the serialized output in case you have any concern
from prebid-server-java.
Key decision that should be made and that directly affects implementation is about including usersync status in /openrtb2/auction response. Although there is POJO and place defined in bid response extension for them (bidresponse.ext.usersync.{bidder}.*) filling them in auction response was never implemented for /openrtb2/auction (in contrast with legacy /auction endpoint) even in Go counterpart. That makes sense to me as there is /cookie_sync endpoint for achieving similar result (and making it easier to handle GDPR with regard to initiating usersync - see #63) so I wonder if there is benefit in providing this information in /openrtb2/auction response.
from prebid-server-java.
What's the use case for exposing this information in the externally available auction response object?
What I'm hearing so far is that the data is really only needed internally later in the auction pipeline, not by the client? I don't think we want to expose data that's not needed by a client app/browser -- that could be inefficient, confusing, and/or GDPR-sensitive if cookie-related.
from prebid-server-java.
The PR's comment (#75) already mentions that maybe we should make this field transient, in order to not expose this information to the outside world.
Marfeel does not need to expose this information to the outside world, I agree with you that is useless from the client point of view, we only need it internally, for tracking metrics.
In my opinion the only "natural" way of storing and retrieving this data in both /openrtb2/amp and /openrtb2/auction endpoint is using this POJO field
So should I update the PR in order to make this field not serializable ? (not visible to the outside world)
from prebid-server-java.
Related Issues (20)
- Port PR from PBS-Go: Update prebid.org url to https HOT 1
- Metrics Documentation Outdated Re: `/cookie_sync` endpoint metrics HOT 1
- Port PR from PBS-Go: Taboola: Fix gpp query param
- Port PR from PBS-Go: DSA: Bid response adrender, behalf & paid validations HOT 1
- Port PR from PBS-Go: Criteo: add GPP macros
- Port PR from PBS-Go: TheMediaGrid: Add GPP macros HOT 1
- Port PR from PBS-Go: Rubicon: Remove api validation HOT 1
- Port PR from PBS-Go: Medianet: Upgrades to OpenRTB 2.6 HOT 1
- Port PR from PBS-Go: Adnuntius: site.ext targeting
- Port PR from PBS-Go: Privacy Sandbox: support testing label header HOT 1
- Exceptions handling (null handling) HOT 2
- Port PR from PBS-Go: New Adapter: Theadx
- Port PR from PBS-Go: RTB House: regional endpoints HOT 1
- Port PR from PBS-Go: iqzone get media type from mtype bid property HOT 1
- Port PR from PBS-Go: New Adapter: Roulax
- Delete tag master - creates spurious warning when checking out HOT 1
- Port PR from PBS-Go: Evolution Bid Adapter: add iframe to userSync
- Port PR from PBS-Go: MgidX Bid Adapter: add disabled param
- Port PR from PBS-Go: New Analytics Adapter: agma
- Port PR from PBS-Go: Fix loading of default bid adjustments for account_defaults
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prebid-server-java.