Comments (6)
Added issue in Nim repo about calling finalizers on thread exit: nim-lang/Nim#12192
from godot-nim.
I have a feeling you're going to run into a lot of issues with accessing foreign threads in Nim. Might want to take a look at the Nim docs around - setupForeignThreadGC
from godot-nim.
This is not about accessing foreign threads, but rather accessing Godot from threads created in Nim.
This is currently not supported, but should be easy to implement by changing classRegistry
to be a shared non-GC hash table rather than standard TableRef. Since classRegistry
is populated only at initialization time and later accessed as read-only, it can be implemented without any locking.
from godot-nim.
but should be easy to implement by changing classRegistry to be a shared non-GC hash table
That's exactly what I did. The program is running just fine, but I'm concerned about memory leaks. I'm using a GC_fullCollect
when the thread finishes, otherwise I have errors of PoolArrays and Godot objects that haven't been deallocated. I'm wondering if this is the correct way of dealing with the GC.
from godot-nim.
I think that can be considered a bug in Nim - it doesn't run finalizers before deallocating thread's GC memory. It also doesn't do that in tearDownForeignThreadGc
, which is a bug.
I'd recommend calling deallocHeap(runFinalizers = true, allowGcAfterwards = false)
instead of GC_fullCollect()
. That would ensure that everything is deallocated, but it has to be called right before thread exits. GC_fullCollect()
may leave out things that are still on the stack, even if actually unused, because it has to be conservative about stack memory.
from godot-nim.
Using deallocHeap is not working for me. On exit it throws the following error:
ERROR: : Unhandled Nim exception: C:\Users\fallo.nimble\pkgs\godot-0.7.22\nim\godotnim.nim(890) godot_gdnative_terminate
D:\nim-0.20.2\lib\system\gc_common.nim(432) deallocHeap
D:\nim-0.20.2\lib\system\gc_common.nim(420) prepareDealloc
C:\Users\fallo.nimble\pkgs\godot-0.7.22\nim\godotnim.nim(197) nimGodotObjectFinalizer
C:\Users\fallo.nimble\pkgs\godot-0.7.22\nim\godotnim.nim(169) unreference
C:\Users\fallo.nimble\pkgs\godot-0.7.22\godotinternal.nim(19) ptrCall
Error: unhandled exception: Could not access value because it is nil. [NilAccessError]At: godotnim.nim:927
CrashHandlerException: Program crashed
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[0] _atomic_decrement_impl (D:\Users\fallo\Godot\Source\core\safe_refcount.cpp:67)
[1] atomic_decrement (D:\Users\fallo\Godot\Source\core\safe_refcount.cpp:128)
[2] SafeRefCount::unrefval (D:\Users\fallo\Godot\Source\core\safe_refcount.h:198)
[3] Reference::unreference (D:\Users\fallo\Godot\Source\core\reference.cpp:84)
[4] MethodBind0R<Reference,bool>::ptrcall (D:\Users\fallo\Godot\Source\core\method_bind.gen.inc:334)
[5] godot_method_bind_ptrcall (D:\Users\fallo\Godot\Source\modules\gdnative\gdnative\gdnative.cpp:70)
[6] ptrCall_J9clFxPbb8WTsAncRkkEw0Qgodotinternal (C:\Users\fallo.nimble\pkgs\godot-0.7.22\godotinternal.nim:20)
[7] unreference_j9bzXaMpeSQDwrtjw0a5Y7Q (C:\Users\fallo.nimble\pkgs\godot-0.7.22\nim\godotnim.nim:170)
[8] nimGodotObjectFinalizer_lqbHYZW6vM10ix5zsGGHyg (C:\Users\fallo.nimble\pkgs\godot-0.7.22\nim\godotnim.nim:197)
[9] prepareDealloc_fvhnFro5wEfzy879alizcUQ (D:\nim-0.20.2\lib\system\gc_common.nim:421)
[10] deallocHeap_7bQwx7xAIUIugRIQt0epPg (D:\nim-0.20.2\lib\system\alloc.nim:390)
[11] godot_gdnative_terminate (C:\Users\fallo.nimble\pkgs\godot-0.7.22\nim\godotnim.nim:893)
[12] GDNative::terminate (D:\Users\fallo\Godot\Source\modules\gdnative\gdnative.cpp:424)
[13] NativeScriptLanguage::~NativeScriptLanguage (D:\Users\fallo\Godot\Source\modules\gdnative\nativescript\nativescript.cpp:1045)
[14] NativeScriptLanguage::`scalar deleting destructor'
[15] memdelete (D:\Users\fallo\Godot\Source\core\os\memory.h:118)
[16] unregister_nativescript_types (D:\Users\fallo\Godot\Source\modules\gdnative\nativescript\register_types.cpp:72)
[17] unregister_gdnative_types (D:\Users\fallo\Godot\Source\modules\gdnative\register_types.cpp:307)
[18] unregister_module_types (D:\Users\fallo\Godot\Source\modules\register_module_types.gen.cpp:206)
[19] Main::cleanup (D:\Users\fallo\Godot\Source\main\main.cpp:2078)
[20] widechar_main (D:\Users\fallo\Godot\Source\platform\windows\godot_windows.cpp:164)
[21] _main (D:\Users\fallo\Godot\Source\platform\windows\godot_windows.cpp:184)
[22] main (D:\Users\fallo\Godot\Source\platform\windows\godot_windows.cpp:196)
[23] __scrt_common_main_seh (d:\agent_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[24] BaseThreadInitThunk
-- END OF BACKTRACE --
from godot-nim.
Related Issues (20)
- Nim constructor not found for class BulletPhysicsDirectSpaceState HOT 1
- Issue with connecting signal BodyEntered (area) HOT 1
- Generate .dll for other platforms (like Linux) HOT 4
- New native extension system for 4.0 HOT 1
- Basis getEuler behavior
- Add proc directionTo for vector2 and vector3
- GDExtentions Support HOT 1
- Nake Build Error HOT 14
- Nake build failed if GODOT_BIN path contains space character
- How to deal with exceptions? (and other beginner notes) HOT 7
- Documentation search doesn't do anything
- Export questions HOT 2
- Is this abandoned? What's happening HOT 4
- nake build error:: type expected but got symbol 'Array' of kind 'enumField' HOT 2
- godot-nim crashing godot (windows 10) [Solved?]
- I can't find the answers
- Error: type expected, but got symbol 'Array' of kind 'enumField' HOT 1
- is this abandoned? HOT 7
- Output is flooding with `A foreign thread is created` when i use NavigationAgent
- Cant compile to wasm
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godot-nim.