Comments (2)
cfcs
commented on August 15, 2024
This did the trick:
diff --git a/lwt/notty_lwt.ml b/lwt/notty_lwt.ml
index b30c622..ab86ad1 100644
--- a/lwt/notty_lwt.ml
+++ b/lwt/notty_lwt.ml
@@ -65,7 +65,7 @@ module Term = struct
| Left n -> Unescape.input flt ibuf 0 n; next ()
| Right _ -> Lwt.return_none
in Lwt_stream.from next in
- Lwt.async (fun () -> Lwt_stream.closed stream >|= fun _ -> f);
+ Lwt.async (fun () -> Lwt_stream.closed stream >|= fun _ -> f () );
```
Alternatively I guess you could do `Lwt.async (fun () -> Lwt_stream.closed stream >|= f );`from notty.
pqwy
commented on August 15, 2024
@cfcs Fantastically sweet catch, thank you!
@ttamttam Imagine that I never once ran into this. So I just assumed it's a race somewhere, to be investigated not-today.
But the fix clearly demonstrates that notty is broken, in a very deterministic way!
Turns out that zsh will stty for you before drawing the prompt. For years, I never saw the actual effects of the clean-up code. 😆
from notty.
Related Issues (20)
- Dune support HOT 2
- Possible extensions to the image combinators HOT 9
- What is Gen_output for? HOT 1
- Structure dumper example HOT 5
- `Notty.Unescape.next` doesn't seem to parse Arrow escape sequence HOT 10
- Vertical stacking on WSL (Ubuntu subsystem on Windows 10) does not work. HOT 1
- `pending` seems to not work using unix backend HOT 1
- New version in opam
- Not all examples will be built HOT 3
- Question: Where is an example about red-black trees?
- Converting rgb_888 to rgb
- I can't get any of the examples to work HOT 3
- Respond to SIGTSTP/SIGSTOP nicely
- Add mouse movement
- [OCaml 5.0] Eio compatibility
- circular dependency between unmark.cli and notty
- Support OSC 8 (hyperlinks)
- Windows support
- Support for placing and showing the cursor HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notty.