Include subdirectory? about citar-denote HOT 7 CLOSED

I'll have to read the Denote manual how it treats subdirs, It is certainly feasible, Only two functions in citar-denote are directory-specific.

from citar-denote.

Excellent - I have pushed this version.

from citar-denote.

Hi Colin, I am about release a new version (which allows multiple notes per entry and multiple entries per note), so I am happy to weave this in as well.

What is the denote-subdir variable?

from citar-denote.

Another question. I don't use subdirectories so cannot test your suggestion.

When you use multiple folders, does the denote-directory-files-matching-regexp function list all notes in all folders? I use this function to check for reference keys.

from citar-denote.

What is the denote-subdir variable?

That was just a dummy variable for the sample function I gave above. I figure since not everyone uses subdirs better to have the option to not show the subdir prompt.

When you use multiple folders, does the denote-directory-files-matching-regexp function list all notes in all folders?

As far as I can tell it does. I haven't tested it extensively but it picks up the references that are properly formatted in my refs-dir subdirectory.

from citar-denote.

I think it is as easy as you indicated. I added:

(defcustom citar-denote-subdir 't
  "Ask for a subdirectory when creating a new bibliographic note.")

And changed the creation function as suggested:

(defun citar-denote-create-note (key &optional _entry)
  "Create a bibliography note for `KEY' with properties `ENTRY'.

The file type for the note to be created is determined by `denote-file-type'.
When `citar-denote-subdir' is non-nil, prompt for a subdirectory."
  (denote
   (read-string "Title: " (citar-get-value "title" key))
   (citar-denote-keywords-prompt)
   citar-denote-file-type
   (when citar-denote-subdir (denote-subdirectory-prompt)))
  (citar-denote-add-reference key citar-denote-file-type))

Can you test and confirm that this is what you need? If so, then I will commit the new version.

from citar-denote.

Yes -- that works well! Thanks!

from citar-denote.