Giter Club home page Giter Club logo

Comments (6)

patfelst avatar patfelst commented on June 1, 2024

you'll have to code it yourself. Just copy one of the other PID functions, and replace the PID with 166. Something like this (I've not tested it):

uint8_t ELM327::odometer()
{
	return (uint8_t)processPID(SERVICE_01, 166, 1, 4, 0.1);

}

Note that it returns 4 bytes, and you need to divide the result by 10 (that's what the 0.1 scale factor is for)

from elmduino.

vizziniroberto71 avatar vizziniroberto71 commented on June 1, 2024

Hi Patrick,
thanks for your suggestion, I modified the library to also read the odometer value, but when compiling it returns the following error:
c:\Users\Administrator\Documents\Arduino\libraries\ELMDuino\src\ELMduino.cpp: In member function 'uint32_t ELM327::supportedPIDs_161_192()':
c:\Users\Administrator\Documents\Arduino\libraries\ELMDuino\src\ELMduino.cpp:2261:42: error: 'SUPPORTED_PIDS_161_192' was not declared in this scope
return (uint32_t)processPID(SERVICE_01, SUPPORTED_PIDS_161_192, 1, 4);
^~~~~~~~~~~~~~~~~~~~~~
c:\Users\Administrator\Documents\Arduino\libraries\ELMDuino\src\ELMduino.cpp:2261:42: note: suggested alternative: 'SUPPORTED_PIDS_61_80'
return (uint32_t)processPID(SERVICE_01, SUPPORTED_PIDS_161_192, 1, 4);
^~~~~~~~~~~~~~~~~~~~~~
SUPPORTED_PIDS_61_80
c:\Users\Administrator\Documents\Arduino\libraries\ELMDuino\src\ELMduino.cpp: In member function 'uint32_t ELM327::odometer()':
c:\Users\Administrator\Documents\Arduino\libraries\ELMDuino\src\ELMduino.cpp:2284:42: error: 'ODOMETER' was not declared in this scope
return (uint32_t)processPID(SERVICE_01, ODOMETER, 1, 4, 1.0 / 10.0);

this error is returned at compile time. The changes made on the two library files are:
`uint32_t supportedPIDs_161_192();

uint32_t odometer();`
these lines have been inserted in the elmduino.h file!

In the elmduino.cpp file i inserted:

uint32_t ELM327::supportedPIDs_161_192()
{
return (uint32_t)processPID(SERVICE_01, SUPPORTED_PIDS_161_192, 1, 4);
}

uint32_t ELM327::odometer()
{
return (uint32_t)processPID(SERVICE_01, ODOMETER, 1, 4, 1.0 / 10.0);
}

I'm sorry if I bother you for this triviality, but I can't understand the error and it is the last step of the project that is still missing.
Thank you.

Roberto.

from elmduino.

patfelst avatar patfelst commented on June 1, 2024

I wouldn't worry about the uint32_t supportedPIDs_161_192(), it's not needed, for the moment, lets just assume your vehicle supports reporting of odometer.

Also you've referenced ODOMETER when it hasn't been defined in the .h file. To start with, just hard code everything as per my example, if it works, then maybe it's worth defining ODOMETER constant etc. I assumed you knew you needed to add the function prototype to the class.

In the .h file where all the other functions are defined - it doesn't really matter where - but I suggest here


add uint8_t odometer();

and paste in the original function I provided in the .cpp file.

that should be all you need to do.

from elmduino.

vizziniroberto71 avatar vizziniroberto71 commented on June 1, 2024

from elmduino.

patfelst avatar patfelst commented on June 1, 2024

try turning debug on to see what your vehicle is reporting - this will be independent of your Nextion display.

have a look at the multiple PIDs example for how to turn debug on
https://github.com/PowerBroker2/ELMduino/blob/master/examples/multiple_pids/multiple_pids.ino

from elmduino.

vizziniroberto71 avatar vizziniroberto71 commented on June 1, 2024

from elmduino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.