Skipping a validator about ember-changeset-validations HOT 9 OPEN

I've been playing around with a pattern like this for conditional validations over the past couple days.

It seems to work really nicely with the exception of needing to explicitly revalidate dependent fields whenever a field involved in a condition changes — I noticed the existing confirmation validator has the same issue where it doesn't revalidate if the value of its on field changes.

@poteto Do you have any thoughts on what first-class support for dependent validations might look like?

from ember-changeset-validations.

I encountered this use case as well and came up with the below. It's not too pretty but I think it's straightforward and versatile:

// Validate presence only if underlying model isNew
{
  quantity: [
    function(key, newValue, oldValue, changes, content) {
      if (content.get('isNew')) {
        return validatePresence(true)(...arguments);
      }
      return true;
    }
  ]
}

You could of course make it dependent on a value in changes. Given the philosophy behind validators being "just functions", I think it should work pretty well?

from ember-changeset-validations.

@celicoo I think the goal is to be able to programmatically enable/disable validations based on the value of other fields in the changeset.

from ember-changeset-validations.

+1
It would ve great if we could enable or disable each validation rule on the fly.

from ember-changeset-validations.

Would be great if this was supported out of the box.
I'm currently building a multi-step form, and would like to validate certain fields at a time.

from ember-changeset-validations.

I am now setting the property to 0 if the condition is fulfilled which causes the above input not to be rendered. This is probably acceptable for this use case, but I wonder if there might circumstances in the future where the property should be left as null or undefined and not set to 0 (i.e. there might be another place where this property is tested for undefined/null), and where skipping the validator would be a preferable option.

from ember-changeset-validations.

@dfreeman To be honest I have not, but I like what your conditional validator does. Let me experiment a little more. In the meantime, if you would like to make your conditional validator a plugin to e-c-v that would be great :)

from ember-changeset-validations.

I encountered this use case as well and came up with the below. It's not too pretty but I think it's straightforward and versatile:

// Validate presence only if underlying model isNew
{
  quantity: [
    function(key, newValue, oldValue, changes, content) {
      if (content.get('isNew')) {
        return validatePresence(true)(...arguments);
      }
      return true;
    }
  ]
}

You could of course make it dependent on a value in changes. Given the philosophy behind validators being "just functions", I think it should work pretty well?

How can I do that using more than one validator? Something like this:

if (content.get('isNew')) {
  return [validatePresence(true)(...arguments), myCustomValidator()]
}

from ember-changeset-validations.

quantity: [
    function(key, newValue, oldValue, changes, content) {
      if (content.get('isNew')) {
        return validatePresence(true)(...arguments);
      }
      return true;
    }
  ]

The answer to my own question would be :

quantity: [
    function(key, newValue, oldValue, changes, content) {
      if (content.get('condition1')) {
        return validatePresence(true)(...arguments);
      }
      return true;
    },
    function(key, newValue, oldValue, changes, content) {
      if (content.get('condition2')) {
        return validateSomethingElse(true)(...arguments);
      }
      return true;
    }
  ]```

from ember-changeset-validations.