Correct formatting about powershellpracticeandstyle HOT 5 CLOSED

Whatever looks right to you is probably the best answer, it's probably a heavily opinionated area like a few others around style. Personally I prefer the second so it's more clear it's part of that single command.

from powershellpracticeandstyle.

Remove the Measure-Object entirely since it's not adding anything that isn't already provided by PS.

You could conceivably also drop the parents and name the variable books, then in the if do $books.count, because presumably you actually care what the books are later in your script so should only look them up once and reuse that variable and it's contents later.

from powershellpracticeandstyle.

That script is just for example. I just wonder to know the best approach in such cases

from powershellpracticeandstyle.

Taking into account that the code is obviously for demo purposes only. I would suggest splatting the parameters for Get-ChildItem for example

$Params = @{
    Path = $MyBooksDir
    Recurse = $true
    File = $true
    Include = '*.txt', '*.pdf', '*.doc*'
}
$NumberOfBooks = (Get-ChildItem @Params | Measure-Object).Count
if ($NumberOfBooks -gt 1000) {
    Write-Host "There are $NumberOfBooks books in the folder. Are you sure you can read that much?"
}

Also I would use PascalCase for variable names to align with the PowerShellPracticeAndStyle Capitalization guidelines but this is obviously personal preference.

from powershellpracticeandstyle.

For what it's worth (and to demonstrate that this is very much a matter of taste), I would probably just leave it that long. I've got 24" monitors, and my "you should wrap soon" line is set at 120, but ....

But if I did want to shorten that, I would go ahead and wrap on the parenthesis to give myself more space, and then maybe write it like this:

$numberOfBooks = (
    Get-ChildItem $myBooksDir -Recurse -File -Include '*.txt', '*.pdf', '*.doc*' |
        Measure-Object
).Count

if ($numberOfBooks -gt 1000) {
    Write-Host "There are $numberOfBooks books in the folder. Are you sure you can read that much?"
}

from powershellpracticeandstyle.