Welcome API fails when running in docker local about porter HOT 5 CLOSED

Ah, the issue is that config WELCOME_FORM_WEBHOOK is empty by default, and is not being checked before attempting a request.

Lazy workaround is setting -e WELCOME_FORM_WEBHOOK="https://httpbin.org/get" when running with docker.

from porter.

This issue doesn't occur on master branch in the dev environments, but it does with the latest v0.36.0 docker image.

from porter.

Hey @dustinblackman, thanks for the bug report! Is WELCOME_FORM_WEBHOOK set in your ./docker/.env file? I'm not quite sure why this wouldn't be impacting the docker dev environments as well.

That said, the easiest fix is probably to check for the webhook in the handler, as you mentioned. Let me know if you'd like to open up a PR, otherwise we'll pick this up for a patch release 👍

from porter.

@abelanger5 Ah okay! So I believe it's missing from the docs, which is why I initially had it missing. Not sure why it's acting different between the two environments.

I'd be happy to PR a fix, but depends on what the expectations are. Is WELCOME_FORM_WEBHOOK expected to be a required variable? If yes I can update docs and env setups. if no I can check if it exists first so the request doesn't fail.

from porter.

No, it's not expected to be required. Checking it in the request definitely makes sense!

from porter.