Comments (6)
I am happy to take a stab at this if no-one else is working on this. I love the idea of supporting markdown and if this works, would we be open to the idea of also allowing markdown for posts? We can start with comments and see how it goes. Okay to take a quick attempt at this if no-one else is working on this?
I can try and submit a PR in a couple of weeks.
from dasblog-core.
@thousandtyone I wanted this to be option 2. Thanks for the checking!
from dasblog-core.
@thousandtyone Thanks!
from dasblog-core.
I've started working on this and have a quick question.
Today the HTML tags allowed are limited. By introducing markdown are we completely removing the limit on markdown options allowed. For example in my comment can I type "# Hello" and the converted HTML will convert it into <h1>Hello</h1>
- or do we also wanted users to use a restricted set of mark down options like allowing just bold, italics etc.? When we talk of simplifying the code I am thinking we want to remove all restrictions and allow everything in comments that markdown allows (Even if it means users can now inject H1 and H2 headers using markdown). Is this understanding correct?
(Another option is we have the same set of restrictions on what kind of tags we support today but allow the users to enter these using markdown).
Which one of the two options are we leaning towards? 1) allow everything that markdown allows? 2) have the same set of restrictions that we have today but allow users to use markdown instead of HTML?
from dasblog-core.
@poppastring - I've submitted a PR. Feel free take a look at it and please do let me know if any changes are needed. I've documented it extensively in the PR comments. Also introduced a site.config setting to allow markdown which is off by default to retain backward compatibility. Feel free to review the PR and the comments associated with the PR and I'll be happy to make any modifications that might be needed. Please do let me know. Note: The PR goes with the option we discussed in the thread.
from dasblog-core.
from dasblog-core.
Related Issues (20)
- Support multiple users HOT 1
- ActivityPub support HOT 2
- Upgrade to .NET 7 HOT 1
- Add Rate limitation Policy to authentication endpoints HOT 1
- Create WebFinger support
- Update the admin page style HOT 1
- Replace Selenium with Playwright
- Hyperlinks in Comments Don't Work HOT 1
- When the site is installed into a subdirectory, the "post" create/edit operations sucecss but redirect to /post HOT 1
- Use hashtags for categories.
- Use CloudEvents for enabling event-driven notifications including cross-posting.
- Distinct endpoint handler for binaries/images uploads HOT 1
- "Microblog" support HOT 2
- Need to enhance documentation for blog deployment options. HOT 6
- Trying to publish as self-contained app HOT 1
- Themes folder is hard coded as "theme" in DasBlogSettings causing custom themes css and shortcuticons to 404 HOT 4
- Support For Static Pages? HOT 6
- .NET 8 Upgrade LTS
- Category URLs for Older Das Blog Migration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dasblog-core.